Modified: trunk/Tools/ChangeLog (234633 => 234634)
--- trunk/Tools/ChangeLog 2018-08-06 22:35:50 UTC (rev 234633)
+++ trunk/Tools/ChangeLog 2018-08-06 23:49:09 UTC (rev 234634)
@@ -1,3 +1,18 @@
+2018-08-06 David Quesada <david_ques...@apple.com>
+
+ webkitdirs.pm should default to iPhone SE for 64-bit testing
+ https://bugs.webkit.org/show_bug.cgi?id=188361
+
+ Reviewed by Daniel Bates.
+
+ Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
+
+ * Scripts/webkitdirs.pm:
+ (findOrCreateSimulatorForIOSDevice):
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (parse_args):
+ Update the help text for --device-type to reflect the new default device.
+
2018-08-06 Wenson Hsieh <wenson_hs...@apple.com>
[iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
Modified: trunk/Tools/Scripts/webkitdirs.pm (234633 => 234634)
--- trunk/Tools/Scripts/webkitdirs.pm 2018-08-06 22:35:50 UTC (rev 234633)
+++ trunk/Tools/Scripts/webkitdirs.pm 2018-08-06 23:49:09 UTC (rev 234634)
@@ -2670,8 +2670,8 @@
my $simulatorName;
my $simulatorDeviceType;
if (architecture() eq "x86_64") {
- $simulatorName = "iPhone 5s " . $simulatorNameSuffix;
- $simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-5s";
+ $simulatorName = "iPhone SE " . $simulatorNameSuffix;
+ $simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-SE";
} else {
$simulatorName = "iPhone 5 " . $simulatorNameSuffix;
$simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-5";
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (234633 => 234634)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2018-08-06 22:35:50 UTC (rev 234633)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2018-08-06 23:49:09 UTC (rev 234634)
@@ -296,7 +296,7 @@
optparse.make_option('--no-install', action='', const=False, default=True, dest='install',
help='Skip install step for device and simulator testing'),
optparse.make_option('--version', help='Specify the version of iOS to be used. By default, this will adopt the runtime for iOS Simulator.'),
- optparse.make_option('--device-type', help='iOS Simulator device type identifier (default: i386 -> iPhone 5, x86_64 -> iPhone 5s)'),
+ optparse.make_option('--device-type', help='iOS Simulator device type identifier (default: i386 -> iPhone 5, x86_64 -> iPhone SE)'),
optparse.make_option('--dedicated-simulators', action="" default=False,
help="If set, dedicated iOS simulators will always be created. If not set, the script will attempt to use any currently running simulator."),
optparse.make_option('--show-touches', action="" default=False, help="If set, a small dot will be shown where the generated touches are. Helpful for debugging touch tests."),
