Title: [234962] trunk/Tools
- Revision
- 234962
- Author
- jer.no...@apple.com
- Date
- 2018-08-16 15:37:22 -0700 (Thu, 16 Aug 2018)
Log Message
Add option to run-api-tests to force running of DISABLED tests.
https://bugs.webkit.org/show_bug.cgi?id=188674
Reviewed by Joseph Pecoraro.
* Scripts/webkitpy/api_tests/run_api_tests.py:
(parse_args):
* Scripts/webkitpy/api_tests/runner.py:
(Runner.command_for_port):
(_Worker._run_single_test):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (234961 => 234962)
--- trunk/Tools/ChangeLog 2018-08-16 22:11:48 UTC (rev 234961)
+++ trunk/Tools/ChangeLog 2018-08-16 22:37:22 UTC (rev 234962)
@@ -1,3 +1,16 @@
+2018-08-16 Jer Noble <jer.no...@apple.com>
+
+ Add option to run-api-tests to force running of DISABLED tests.
+ https://bugs.webkit.org/show_bug.cgi?id=188674
+
+ Reviewed by Joseph Pecoraro.
+
+ * Scripts/webkitpy/api_tests/run_api_tests.py:
+ (parse_args):
+ * Scripts/webkitpy/api_tests/runner.py:
+ (Runner.command_for_port):
+ (_Worker._run_single_test):
+
2018-08-16 Aakash Jain <aakash_j...@apple.com>
[ews-build] Separate queues for Builders and Testers - macOS High Sierra
Modified: trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py (234961 => 234962)
--- trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py 2018-08-16 22:11:48 UTC (rev 234961)
+++ trunk/Tools/Scripts/webkitpy/api_tests/run_api_tests.py 2018-08-16 22:37:22 UTC (rev 234962)
@@ -120,6 +120,9 @@
# FIXME: Default should be false, API tests should not be forced to run singly
optparse.make_option('--run-singly', action='', default=True,
help='Run a separate process for each test'),
+
+ optparse.make_option('--force', action='', default=False,
+ help='Run all tests, even DISABLED tests'),
]))
option_parser = optparse.OptionParser(usage='%prog [options] [<path>...]')
Modified: trunk/Tools/Scripts/webkitpy/api_tests/runner.py (234961 => 234962)
--- trunk/Tools/Scripts/webkitpy/api_tests/runner.py 2018-08-16 22:11:48 UTC (rev 234961)
+++ trunk/Tools/Scripts/webkitpy/api_tests/runner.py 2018-08-16 22:37:22 UTC (rev 234962)
@@ -66,6 +66,8 @@
# FIXME API tests should run as an app, we won't need this function <https://bugs.webkit.org/show_bug.cgi?id=175204>
@staticmethod
def command_for_port(port, args):
+ if (port.get_option('force')):
+ args.append('--gtest_also_run_disabled_tests=1')
if 'simulator' in port.port_name:
assert SimulatedDeviceManager.INITIALIZED_DEVICES
return ['/usr/bin/xcrun', 'simctl', 'spawn', SimulatedDeviceManager.INITIALIZED_DEVICES[0].udid] + args
@@ -159,7 +161,7 @@
env=self._port.environment_for_api_tests())
status = Runner.STATUS_RUNNING
- if test.split('.')[1].startswith('DISABLED_'):
+ if test.split('.')[1].startswith('DISABLED_') and not self._port.get_option('force'):
status = Runner.STATUS_DISABLED
try:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
