Title: [235386] trunk/Tools
Revision
235386
Author
commit-qu...@webkit.org
Date
2018-08-27 11:22:06 -0700 (Mon, 27 Aug 2018)

Log Message

Allow new vector types to work with the interactive interpreter
https://bugs.webkit.org/show_bug.cgi?id=188988

Patch by Thomas Denney <tden...@apple.com> on 2018-08-27
Reviewed by Myles C. Maxfield.

* WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
(FlattenedStructOffsetGatherer.prototype.visitTypeRef): Do not
unncessarily visit the type arguments of a TypeRef, as by this point
there are none that are relevant.
* WebGPUShadingLanguageRI/Intrinsics.js:
(Intrinsics): Treat VectorType as a primitive type.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (235385 => 235386)


--- trunk/Tools/ChangeLog	2018-08-27 17:54:04 UTC (rev 235385)
+++ trunk/Tools/ChangeLog	2018-08-27 18:22:06 UTC (rev 235386)
@@ -1,3 +1,17 @@
+2018-08-27  Thomas Denney  <tden...@apple.com>
+
+        Allow new vector types to work with the interactive interpreter
+        https://bugs.webkit.org/show_bug.cgi?id=188988
+
+        Reviewed by Myles C. Maxfield.
+
+        * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
+        (FlattenedStructOffsetGatherer.prototype.visitTypeRef): Do not
+        unncessarily visit the type arguments of a TypeRef, as by this point
+        there are none that are relevant.
+        * WebGPUShadingLanguageRI/Intrinsics.js:
+        (Intrinsics): Treat VectorType as a primitive type.
+
 2018-08-27  Keith Rollin  <krol...@apple.com>
 
         Build system support for LTO

Modified: trunk/Tools/WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js (235385 => 235386)


--- trunk/Tools/WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js	2018-08-27 17:54:04 UTC (rev 235385)
+++ trunk/Tools/WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js	2018-08-27 18:22:06 UTC (rev 235386)
@@ -59,7 +59,6 @@
     
     visitTypeRef(node)
     {
-        super.visitTypeRef(node);
         Node.visit(node.type, this);
     }
 

Modified: trunk/Tools/WebGPUShadingLanguageRI/Intrinsics.js (235385 => 235386)


--- trunk/Tools/WebGPUShadingLanguageRI/Intrinsics.js	2018-08-27 17:54:04 UTC (rev 235385)
+++ trunk/Tools/WebGPUShadingLanguageRI/Intrinsics.js	2018-08-27 18:22:06 UTC (rev 235386)
@@ -311,6 +311,7 @@
             for (let vectorSize of VectorElementSizes) {
                 this._map.set(`native typedef vector<${vectorType}, ${vectorSize}>`, type => {
                     this[`vector<${vectorType}, ${vectorSize}>`] = type;
+                    type.isPrimitive = true;
                 });
             }
         }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to