Title: [235405] trunk/Tools
- Revision
- 235405
- Author
- achristen...@apple.com
- Date
- 2018-08-27 15:23:03 -0700 (Mon, 27 Aug 2018)
Log Message
Fix API test after r235398
https://bugs.webkit.org/show_bug.cgi?id=188997
* TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::willGoToBackForwardListItem): Deleted.
willGoToBackForwardListItem is unused and unsupported. Removing its check.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235404 => 235405)
--- trunk/Tools/ChangeLog 2018-08-27 22:19:52 UTC (rev 235404)
+++ trunk/Tools/ChangeLog 2018-08-27 22:23:03 UTC (rev 235405)
@@ -1,3 +1,13 @@
+2018-08-27 Alex Christensen <achristen...@webkit.org>
+
+ Fix API test after r235398
+ https://bugs.webkit.org/show_bug.cgi?id=188997
+
+ * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
+ (TestWebKitAPI::setPageLoaderClient):
+ (TestWebKitAPI::willGoToBackForwardListItem): Deleted.
+ willGoToBackForwardListItem is unused and unsupported. Removing its check.
+
2018-08-27 Daniel Bates <daba...@apple.com>
Partial revert of r235376
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp (235404 => 235405)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp 2018-08-27 22:19:52 UTC (rev 235404)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp 2018-08-27 22:23:03 UTC (rev 235405)
@@ -101,12 +101,6 @@
}
}
-static void willGoToBackForwardListItem(WKPageRef, WKBackForwardListItemRef item, WKTypeRef userData, const void*)
-{
- if (!itemURLLastComponentIsString(item, "simple.html"))
- successfulSoFar = false;
-}
-
static bool shouldKeepCurrentBackForwardListItemInList(WKPageRef page, WKBackForwardListItemRef item, const void*)
{
// We make sure the item for "simple2.html" is removed when we navigate to "simple3.html"
@@ -123,7 +117,6 @@
loaderClient.base.version = 5;
loaderClient.didFinishLoadForFrame = didFinishLoadForFrame;
loaderClient.shouldKeepCurrentBackForwardListItemInList = shouldKeepCurrentBackForwardListItemInList;
- loaderClient.willGoToBackForwardListItem = willGoToBackForwardListItem;
WKPageSetPageLoaderClient(page, &loaderClient.base);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
