Diff
Modified: trunk/Source/WebCore/ChangeLog (235885 => 235886)
--- trunk/Source/WebCore/ChangeLog 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebCore/ChangeLog 2018-09-11 05:18:31 UTC (rev 235886)
@@ -1,3 +1,21 @@
+2018-09-10 Fujii Hironori <hironori.fu...@sony.com>
+
+ Remove unused needsDestruction class variables from HashTraits
+ https://bugs.webkit.org/show_bug.cgi?id=189490
+
+ Reviewed by Daniel Bates.
+
+ needsDestruction has been obsoleted in Bug 121983.
+
+ No new tests (No behavior change).
+
+ * css/makeprop.pl: Removed needsDestruction.
+ * platform/graphics/FloatSizeHash.h: Ditto.
+ * platform/graphics/IntPointHash.h: Ditto.
+ * platform/graphics/IntRectHash.h: Ditto.
+ * platform/graphics/IntSizeHash.h: Ditto.
+ * platform/graphics/WidthCache.h: Ditto.
+
2018-09-10 Michael Saboff <msab...@apple.com>
Test262 failure with Named Capture Groups - using a reference before the group is defined
Modified: trunk/Source/WebCore/css/makeprop.pl (235885 => 235886)
--- trunk/Source/WebCore/css/makeprop.pl 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebCore/css/makeprop.pl 2018-09-11 05:18:31 UTC (rev 235886)
@@ -470,7 +470,6 @@
template<> struct DefaultHash<WebCore::CSSPropertyID> { typedef IntHash<unsigned> Hash; };
template<> struct HashTraits<WebCore::CSSPropertyID> : GenericHashTraits<WebCore::CSSPropertyID> {
static const bool emptyValueIsZero = true;
- static const bool needsDestruction = false;
static void constructDeletedValue(WebCore::CSSPropertyID& slot) { slot = static_cast<WebCore::CSSPropertyID>(WebCore::lastCSSProperty + 1); }
static bool isDeletedValue(WebCore::CSSPropertyID value) { return value == (WebCore::lastCSSProperty + 1); }
};
Modified: trunk/Source/WebCore/platform/graphics/FloatSizeHash.h (235885 => 235886)
--- trunk/Source/WebCore/platform/graphics/FloatSizeHash.h 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebCore/platform/graphics/FloatSizeHash.h 2018-09-11 05:18:31 UTC (rev 235886)
@@ -43,7 +43,6 @@
template<> struct HashTraits<WebCore::FloatSize> : GenericHashTraits<WebCore::FloatSize> {
static const bool emptyValueIsZero = true;
- static const bool needsDestruction = false;
static void constructDeletedValue(WebCore::FloatSize& slot) { new (NotNull, &slot) WebCore::FloatSize(-1, -1); }
static bool isDeletedValue(const WebCore::FloatSize& value) { return value.width() == -1 && value.height() == -1; }
};
Modified: trunk/Source/WebCore/platform/graphics/IntPointHash.h (235885 => 235886)
--- trunk/Source/WebCore/platform/graphics/IntPointHash.h 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebCore/platform/graphics/IntPointHash.h 2018-09-11 05:18:31 UTC (rev 235886)
@@ -33,7 +33,6 @@
static const bool safeToCompareToEmptyOrDeleted = true;
};
template<> struct HashTraits<WebCore::IntPoint> : GenericHashTraits<WebCore::IntPoint> {
- static const bool needsDestruction = false;
static WebCore::IntPoint emptyValue() { return WebCore::IntPoint(0, std::numeric_limits<int>::min()); }
static void constructDeletedValue(WebCore::IntPoint& slot) { slot = WebCore::IntPoint(std::numeric_limits<int>::min(), 0); }
Modified: trunk/Source/WebCore/platform/graphics/IntRectHash.h (235885 => 235886)
--- trunk/Source/WebCore/platform/graphics/IntRectHash.h 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebCore/platform/graphics/IntRectHash.h 2018-09-11 05:18:31 UTC (rev 235886)
@@ -48,7 +48,6 @@
template<> struct HashTraits<WebCore::IntRect> : GenericHashTraits<WebCore::IntRect> {
static const bool emptyValueIsZero = true;
- static const bool needsDestruction = false;
static void constructDeletedValue(WebCore::IntRect& slot) { new (NotNull, &slot) WebCore::IntRect(-1, -1, -1, -1); }
static bool isDeletedValue(const WebCore::IntRect& value) { return value.x() == -1 && value.y() == -1 && value.width() == -1 && value.height() == -1; }
};
Modified: trunk/Source/WebCore/platform/graphics/IntSizeHash.h (235885 => 235886)
--- trunk/Source/WebCore/platform/graphics/IntSizeHash.h 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebCore/platform/graphics/IntSizeHash.h 2018-09-11 05:18:31 UTC (rev 235886)
@@ -34,7 +34,6 @@
template<> struct HashTraits<WebCore::IntSize> : GenericHashTraits<WebCore::IntSize> {
static const bool emptyValueIsZero = true;
- static const bool needsDestruction = false;
static void constructDeletedValue(WebCore::IntSize& slot) { new (NotNull, &slot) WebCore::IntSize(-1, -1); }
static bool isDeletedValue(const WebCore::IntSize& value) { return value.width() == -1 && value.height() == -1; }
};
Modified: trunk/Source/WebCore/platform/graphics/WidthCache.h (235885 => 235886)
--- trunk/Source/WebCore/platform/graphics/WidthCache.h 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebCore/platform/graphics/WidthCache.h 2018-09-11 05:18:31 UTC (rev 235886)
@@ -106,7 +106,6 @@
struct SmallStringKeyHashTraits : WTF::SimpleClassHashTraits<SmallStringKey> {
static const bool hasIsEmptyValueFunction = true;
static bool isEmptyValue(const SmallStringKey& key) { return key.isHashTableEmptyValue(); }
- static const bool needsDestruction = false;
static const int minimumTableSize = 16;
};
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (235885 => 235886)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-09-11 05:18:31 UTC (rev 235886)
@@ -1,3 +1,12 @@
+2018-09-10 Fujii Hironori <hironori.fu...@sony.com>
+
+ Remove unused needsDestruction class variables from HashTraits
+ https://bugs.webkit.org/show_bug.cgi?id=189490
+
+ Reviewed by Daniel Bates.
+
+ * History/BinaryPropertyList.cpp: Removed needsDestruction.
+
2018-09-07 Frederic Wang <fw...@igalia.com>
[CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
Modified: trunk/Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp (235885 => 235886)
--- trunk/Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp 2018-09-11 05:07:33 UTC (rev 235885)
+++ trunk/Source/WebKitLegacy/mac/History/BinaryPropertyList.cpp 2018-09-11 05:18:31 UTC (rev 235886)
@@ -76,7 +76,6 @@
}
struct IntegerArrayHashTraits : WTF::GenericHashTraits<IntegerArray> {
- static const bool needsDestruction = false;
static void constructDeletedValue(IntegerArray& slot) { slot.markDeleted(); }
static bool isDeletedValue(const IntegerArray& array) { return array.isDeletedValue(); }
};