Title: [235978] trunk/Source/WebCore
- Revision
- 235978
- Author
- hironori.fu...@sony.com
- Date
- 2018-09-13 10:17:05 -0700 (Thu, 13 Sep 2018)
Log Message
Remove a MSVC workaround in XPath::Step::NodeTest
https://bugs.webkit.org/show_bug.cgi?id=189578
Reviewed by Alex Christensen.
XPath::Step::NodeTest has a special code for MSVC bug workaround.
It has been introduced in 5 years ago in Bug 121082 Comment 19.
I think it is safe just to remove the workaround.
No new tests (No behavior change).
* xml/XPathStep.h: Removed the MSVC workaround.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235977 => 235978)
--- trunk/Source/WebCore/ChangeLog 2018-09-13 17:16:05 UTC (rev 235977)
+++ trunk/Source/WebCore/ChangeLog 2018-09-13 17:17:05 UTC (rev 235978)
@@ -1,5 +1,21 @@
2018-09-13 Fujii Hironori <hironori.fu...@sony.com>
+ Remove a MSVC workaround in XPath::Step::NodeTest
+ https://bugs.webkit.org/show_bug.cgi?id=189578
+
+ Reviewed by Alex Christensen.
+
+ XPath::Step::NodeTest has a special code for MSVC bug workaround.
+ It has been introduced in 5 years ago in Bug 121082 Comment 19.
+
+ I think it is safe just to remove the workaround.
+
+ No new tests (No behavior change).
+
+ * xml/XPathStep.h: Removed the MSVC workaround.
+
+2018-09-13 Fujii Hironori <hironori.fu...@sony.com>
+
Remove a MSVC workaround in InspectorStyle::styleWithProperties
https://bugs.webkit.org/show_bug.cgi?id=189577
Modified: trunk/Source/WebCore/xml/XPathStep.h (235977 => 235978)
--- trunk/Source/WebCore/xml/XPathStep.h 2018-09-13 17:16:05 UTC (rev 235977)
+++ trunk/Source/WebCore/xml/XPathStep.h 2018-09-13 17:17:05 UTC (rev 235978)
@@ -58,27 +58,6 @@
NodeTest(Kind kind, const AtomicString& data) : m_kind(kind), m_data(data) { }
NodeTest(Kind kind, const AtomicString& data, const AtomicString& namespaceURI) : m_kind(kind), m_data(data), m_namespaceURI(namespaceURI) { }
-#if COMPILER(MSVC)
- NodeTest(const NodeTest&);
- void operator=(const NodeTest&);
-
- NodeTest(NodeTest&& other)
- : m_kind(other.m_kind)
- , m_data(WTFMove(other.m_data))
- , m_namespaceURI(WTFMove(other.m_namespaceURI))
- , m_mergedPredicates(WTFMove(other.m_mergedPredicates))
- {
- }
- NodeTest& operator=(NodeTest&& other)
- {
- m_kind = other.m_kind;
- m_data = WTFMove(other.m_data);
- m_namespaceURI = WTFMove(other.m_namespaceURI);
- m_mergedPredicates = WTFMove(other.m_mergedPredicates);
- return *this;
- }
-#endif
-
private:
friend class Step;
friend void optimizeStepPair(Step&, Step&, bool&);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
