Title: [236813] trunk/Source/_javascript_Core
- Revision
- 236813
- Author
- mark....@apple.com
- Date
- 2018-10-03 15:02:44 -0700 (Wed, 03 Oct 2018)
Log Message
Suppress unreachable code warning for LLIntAssembly.h code.
https://bugs.webkit.org/show_bug.cgi?id=190263
<rdar://problem/44986532>
Reviewed by Saam Barati.
This is needed because LLIntAssembly.h is template generated from LowLevelInterpreter
asm files, and may contain dead code which are harmless, but will trip up the warning.
We should suppress the warning so that it doesn't break builds.
* llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (236812 => 236813)
--- trunk/Source/_javascript_Core/ChangeLog 2018-10-03 21:09:42 UTC (rev 236812)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-10-03 22:02:44 UTC (rev 236813)
@@ -1,3 +1,18 @@
+2018-10-03 Mark Lam <mark....@apple.com>
+
+ Suppress unreachable code warning for LLIntAssembly.h code.
+ https://bugs.webkit.org/show_bug.cgi?id=190263
+ <rdar://problem/44986532>
+
+ Reviewed by Saam Barati.
+
+ This is needed because LLIntAssembly.h is template generated from LowLevelInterpreter
+ asm files, and may contain dead code which are harmless, but will trip up the warning.
+ We should suppress the warning so that it doesn't break builds.
+
+ * llint/LowLevelInterpreter.cpp:
+ (JSC::CLoop::execute):
+
2018-10-03 Dan Bernstein <m...@apple.com>
_javascript_Core part of [Xcode] Update some build settings as recommended by Xcode 10
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp (236812 => 236813)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2018-10-03 21:09:42 UTC (rev 236812)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter.cpp 2018-10-03 22:02:44 UTC (rev 236813)
@@ -446,7 +446,9 @@
// bytecode handlers for the interpreter, as compiled from
// LowLevelInterpreter.asm and its peers.
+ IGNORE_CLANG_WARNINGS_BEGIN("unreachable-code")
#include "LLIntAssembly.h"
+ IGNORE_CLANG_WARNINGS_END
OFFLINE_ASM_GLUE_LABEL(llint_return_to_host)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes