Title: [236985] trunk/Source/WebCore
- Revision
- 236985
- Author
- mcatanz...@igalia.com
- Date
- 2018-10-09 14:59:12 -0700 (Tue, 09 Oct 2018)
Log Message
[WPE][GTK] Complex text crashes with harfbuzz 1.8.8
https://bugs.webkit.org/show_bug.cgi?id=190409
Reviewed by Žan Doberšek.
We discovered that harfbuzz 1.8.8 breaks WebKit by changing the ownership semantics of
hb_icu_get_unicode_funcs() from (transfer full) to (transfer none). Our code was actually
expecting (transfer none), so it's not immediately clear to me why it's crashing now, but
doesn't matter as Behdad recommends removing this line of code because it hasn't been
been needed for many years.
This should be covered by all our complex text tests if the bots were upgraded to the newer
harfbuzz.
* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (236984 => 236985)
--- trunk/Source/WebCore/ChangeLog 2018-10-09 21:45:14 UTC (rev 236984)
+++ trunk/Source/WebCore/ChangeLog 2018-10-09 21:59:12 UTC (rev 236985)
@@ -1,3 +1,22 @@
+2018-10-09 Michael Catanzaro <mcatanz...@igalia.com>
+
+ [WPE][GTK] Complex text crashes with harfbuzz 1.8.8
+ https://bugs.webkit.org/show_bug.cgi?id=190409
+
+ Reviewed by Žan Doberšek.
+
+ We discovered that harfbuzz 1.8.8 breaks WebKit by changing the ownership semantics of
+ hb_icu_get_unicode_funcs() from (transfer full) to (transfer none). Our code was actually
+ expecting (transfer none), so it's not immediately clear to me why it's crashing now, but
+ doesn't matter as Behdad recommends removing this line of code because it hasn't been
+ been needed for many years.
+
+ This should be covered by all our complex text tests if the bots were upgraded to the newer
+ harfbuzz.
+
+ * platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
+ (WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
+
2018-10-09 Daniel Bates <daba...@apple.com>
[iOS] Cleanup EventHandler::passSubframeEventToSubframe()
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp (236984 => 236985)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp 2018-10-09 21:45:14 UTC (rev 236984)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp 2018-10-09 21:59:12 UTC (rev 236985)
@@ -193,7 +193,6 @@
const auto& fontPlatformData = font->platformData();
auto features = fontFeatures(m_font, fontPlatformData.orientation());
HbUniquePtr<hb_buffer_t> buffer(hb_buffer_create());
- hb_buffer_set_unicode_funcs(buffer.get(), hb_icu_get_unicode_funcs());
for (unsigned i = 0; i < runCount; ++i) {
auto& run = runList[m_run.rtl() ? runCount - i - 1 : i];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
