Title: [236989] trunk/Source/WebKit
- Revision
- 236989
- Author
- achristen...@apple.com
- Date
- 2018-10-09 16:40:21 -0700 (Tue, 09 Oct 2018)
Log Message
REGRESSION(r231663) loading in hidden WKWebViews stalls because WebProcess is suspended
https://bugs.webkit.org/show_bug.cgi?id=190417
<rdar://problem/43391014>
Reviewed by Chris Dumez.
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::didChangeIsLoading):
Revert r321663, but keep the change to TestWKWebView.mm because that made the tests more reliable.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236988 => 236989)
--- trunk/Source/WebKit/ChangeLog 2018-10-09 23:25:46 UTC (rev 236988)
+++ trunk/Source/WebKit/ChangeLog 2018-10-09 23:40:21 UTC (rev 236989)
@@ -1,3 +1,15 @@
+2018-10-09 Alex Christensen <achristen...@webkit.org>
+
+ REGRESSION(r231663) loading in hidden WKWebViews stalls because WebProcess is suspended
+ https://bugs.webkit.org/show_bug.cgi?id=190417
+ <rdar://problem/43391014>
+
+ Reviewed by Chris Dumez.
+
+ * UIProcess/Cocoa/NavigationState.mm:
+ (WebKit::NavigationState::didChangeIsLoading):
+ Revert r321663, but keep the change to TestWKWebView.mm because that made the tests more reliable.
+
2018-10-09 Chris Dumez <cdu...@apple.com>
Allow behavior when the parent process IPC::Connection closes to be overridden by ChildProcess subclasses
Modified: trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm (236988 => 236989)
--- trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm 2018-10-09 23:25:46 UTC (rev 236988)
+++ trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm 2018-10-09 23:40:21 UTC (rev 236989)
@@ -1104,14 +1104,10 @@
m_activityToken = m_webView->_page->process().throttler().backgroundActivityToken();
}
} else if (m_activityToken) {
- if (m_webView._isBackground)
- releaseNetworkActivityTokenAfterLoadCompletion();
- else {
- // The application is visible so we delay releasing the background activity for 3 seconds to give it a chance to start another navigation
- // before suspending the WebContent process <rdar://problem/27910964>.
- RELEASE_LOG_IF(m_webView->_page->isAlwaysOnLoggingAllowed(), ProcessSuspension, "%p - NavigationState will release its process network assertion soon because the page load completed", this);
- m_releaseActivityTimer.startOneShot(3_s);
- }
+ // The application is visible so we delay releasing the background activity for 3 seconds to give it a chance to start another navigation
+ // before suspending the WebContent process <rdar://problem/27910964>.
+ RELEASE_LOG_IF(m_webView->_page->isAlwaysOnLoggingAllowed(), ProcessSuspension, "%p - NavigationState will release its process network assertion soon because the page load completed", this);
+ m_releaseActivityTimer.startOneShot(3_s);
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
