Title: [237864] trunk/LayoutTests
- Revision
- 237864
- Author
- you...@apple.com
- Date
- 2018-11-06 07:46:13 -0800 (Tue, 06 Nov 2018)
Log Message
Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=191278
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Updating test according upstreamed WPT.
Rebased test accordingly.
* web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt:
* web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html:
LayoutTests:
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (237863 => 237864)
--- trunk/LayoutTests/ChangeLog 2018-11-06 15:26:08 UTC (rev 237863)
+++ trunk/LayoutTests/ChangeLog 2018-11-06 15:46:13 UTC (rev 237864)
@@ -1,3 +1,12 @@
+2018-11-06 Youenn Fablet <you...@apple.com>
+
+ Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=191278
+
+ Reviewed by Eric Carlson.
+
+ * TestExpectations:
+
2018-11-06 Thibault Saunier <tsaun...@igalia.com>
[GStreamer][WebRTC] Implement black frame generation
Modified: trunk/LayoutTests/TestExpectations (237863 => 237864)
--- trunk/LayoutTests/TestExpectations 2018-11-06 15:26:08 UTC (rev 237863)
+++ trunk/LayoutTests/TestExpectations 2018-11-06 15:46:13 UTC (rev 237864)
@@ -2905,5 +2905,3 @@
# FIXME: The behavior of navigator.mediaDevices.enumerateDevices is in flux, skip these tests for now.
http/tests/media/media-stream/enumerate-devices-source-id-persistent.html [ Skip ]
http/tests/media/media-stream/enumerate-devices-source-id.html [ Skip ]
-
-webkit.org/b/237773 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html [ Pass Failure ]
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (237863 => 237864)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-06 15:26:08 UTC (rev 237863)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-11-06 15:46:13 UTC (rev 237864)
@@ -1,3 +1,16 @@
+2018-11-06 Youenn Fablet <you...@apple.com>
+
+ Layout Test imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=191278
+
+ Reviewed by Eric Carlson.
+
+ Updating test according upstreamed WPT.
+ Rebased test accordingly.
+
+ * web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt:
+ * web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html:
+
2018-11-06 Ali Juma <aj...@chromium.org>
[IntersectionObserver] Account for CSS zoom when computing client rects
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt (237863 => 237864)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt 2018-11-06 15:26:08 UTC (rev 237863)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https-expected.txt 2018-11-06 15:46:13 UTC (rev 237864)
@@ -4,7 +4,7 @@
PASS addTrack() with a track and no stream makes ontrack fire with a track and no stream.
PASS addTrack() with a track and a stream makes ontrack fire with a track and a stream.
PASS ontrack fires before setRemoteDescription resolves.
-FAIL addTrack() with two tracks and one stream makes ontrack fire twice with the tracks and shared stream. assert_array_equals: The remote stream == [first track, second track]. property 0, expected object "[object MediaStreamTrack]" but got object "[object MediaStreamTrack]"
+PASS addTrack() with two tracks and one stream makes ontrack fire twice with the tracks and shared stream.
PASS addTrack() for an existing stream makes stream.onaddtrack fire.
PASS stream.onaddtrack fires before setRemoteDescription resolves.
PASS addTrack() with a track and two streams makes ontrack fire with a track and two streams.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html (237863 => 237864)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html 2018-11-06 15:26:08 UTC (rev 237863)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html 2018-11-06 15:46:13 UTC (rev 237864)
@@ -115,10 +115,13 @@
'Second ontrack\'s stream ID matches local stream.');
assert_array_equals(firstTrackEvent.streams, secondTrackEvent.streams,
'ontrack was fired with the same streams both times.');
- assert_array_equals(firstTrackEvent.streams[0].getTracks(),
- [firstTrackEvent.track, secondTrackEvent.track],
- 'The remote stream == [first track, second track].');
+
+ assert_equals(firstTrackEvent.streams[0].getTracks().length, 2, "stream should have two tracks");
+ assert_true(firstTrackEvent.streams[0].getTracks().includes(firstTrackEvent.track), "remoteStream should have the first track");
+ assert_true(firstTrackEvent.streams[0].getTracks().includes(secondTrackEvent.track), "remoteStream should have the second track");
assert_equals(ontrackEventsFired, 2, 'Unexpected number of track events.');
+
+ assert_equals(ontrackEventsFired, 2, 'Unexpected number of track events.');
}, 'addTrack() with two tracks and one stream makes ontrack fire twice with the tracks and shared stream.');
promise_test(async t => {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
