Title: [238217] trunk/Source
Revision
238217
Author
krol...@apple.com
Date
2018-11-14 19:33:40 -0800 (Wed, 14 Nov 2018)

Log Message

Fix #end vs. #endif typo.
https://bugs.webkit.org/show_bug.cgi?id=191668
<rdar://problem/46081704>

Reviewed by Alexey Proskuryakov.

Source/WebCore/SourcesCocoa.txt had a #end that should have been a
#endif. Fix this, an add a check to generate-unified-source-bundles.rb
to detect similar typos.

Source/WebCore:

No new tests -- no changed functionality.

* SourcesCocoa.txt:

Source/WTF:

* Scripts/generate-unified-source-bundles.rb:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (238216 => 238217)


--- trunk/Source/WTF/ChangeLog	2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WTF/ChangeLog	2018-11-15 03:33:40 UTC (rev 238217)
@@ -1,3 +1,17 @@
+2018-11-14  Keith Rollin  <krol...@apple.com>
+
+        Fix #end vs. #endif typo.
+        https://bugs.webkit.org/show_bug.cgi?id=191668
+        <rdar://problem/46081704>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Source/WebCore/SourcesCocoa.txt had a #end that should have been a
+        #endif. Fix this, an add a check to generate-unified-source-bundles.rb
+        to detect similar typos.
+
+        * Scripts/generate-unified-source-bundles.rb:
+
 2018-11-12  Mark Lam  <mark....@apple.com>
 
         Add OOM detection to StringPrototype's substituteBackreferences().

Modified: trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb (238216 => 238217)


--- trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb	2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WTF/Scripts/generate-unified-source-bundles.rb	2018-11-15 03:33:40 UTC (rev 238217)
@@ -273,6 +273,7 @@
             raise "malformed #if" unless line =~ /\A#if\s+(\S+)/
             inDisabledLines = !$featureFlags[$1]
         else
+            raise "malformed preprocessor directive: #{line}" if line =~ /^#/
             raise "duplicate line: #{line} in #{path}" if seen[line]
             seen[line] = true
             result << SourceFile.new(line, sourceFileIndex)

Modified: trunk/Source/WebCore/ChangeLog (238216 => 238217)


--- trunk/Source/WebCore/ChangeLog	2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WebCore/ChangeLog	2018-11-15 03:33:40 UTC (rev 238217)
@@ -1,5 +1,21 @@
 2018-11-14  Keith Rollin  <krol...@apple.com>
 
+        Fix #end vs. #endif typo.
+        https://bugs.webkit.org/show_bug.cgi?id=191668
+        <rdar://problem/46081704>
+
+        Reviewed by Alexey Proskuryakov.
+
+        Source/WebCore/SourcesCocoa.txt had a #end that should have been a
+        #endif. Fix this, an add a check to generate-unified-source-bundles.rb
+        to detect similar typos.
+
+        No new tests -- no changed functionality.
+
+        * SourcesCocoa.txt:
+
+2018-11-14  Keith Rollin  <krol...@apple.com>
+
         Remove VideoFullscreenLayerManager.mm from WebCore/SourcesCocoa.txt
         https://bugs.webkit.org/show_bug.cgi?id=191667
         <rdar://problem/46081286>

Modified: trunk/Source/WebCore/SourcesCocoa.txt (238216 => 238217)


--- trunk/Source/WebCore/SourcesCocoa.txt	2018-11-15 03:32:32 UTC (rev 238216)
+++ trunk/Source/WebCore/SourcesCocoa.txt	2018-11-15 03:33:40 UTC (rev 238217)
@@ -632,7 +632,7 @@
     JSTouchEvent.cpp
     JSTouchList.cpp
 
-#end
+#endif
 
 #if ENABLE_IOS_GESTURE_EVENTS
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to