Title: [238539] trunk
- Revision
- 238539
- Author
- hironori.fu...@sony.com
- Date
- 2018-11-26 17:54:59 -0800 (Mon, 26 Nov 2018)
Log Message
[CMake] Remove ENABLE_ACCESSIBILITY CMake variable
https://bugs.webkit.org/show_bug.cgi?id=191831
Reviewed by Michael Catanzaro.
.:
ENABLE_ACCESSIBILITY is a bit confusing name because there is no
such ENABLE_ACCESSIBILITY macros in C++ source files.
* Source/cmake/OptionsGTK.cmake: Removed ENABLE_ACCESSIBILITY.
* Source/cmake/OptionsWPE.cmake: Ditto.
* Source/cmake/OptionsWin.cmake: Ditto.
* Source/cmake/WebKitFeatures.cmake: Ditto.
Tools:
* WebKitTestRunner/CMakeLists.txt:
Modified Paths
Diff
Modified: trunk/ChangeLog (238538 => 238539)
--- trunk/ChangeLog 2018-11-27 01:37:22 UTC (rev 238538)
+++ trunk/ChangeLog 2018-11-27 01:54:59 UTC (rev 238539)
@@ -1,3 +1,18 @@
+2018-11-26 Fujii Hironori <hironori.fu...@sony.com>
+
+ [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
+ https://bugs.webkit.org/show_bug.cgi?id=191831
+
+ Reviewed by Michael Catanzaro.
+
+ ENABLE_ACCESSIBILITY is a bit confusing name because there is no
+ such ENABLE_ACCESSIBILITY macros in C++ source files.
+
+ * Source/cmake/OptionsGTK.cmake: Removed ENABLE_ACCESSIBILITY.
+ * Source/cmake/OptionsWPE.cmake: Ditto.
+ * Source/cmake/OptionsWin.cmake: Ditto.
+ * Source/cmake/WebKitFeatures.cmake: Ditto.
+
2018-11-26 Alberto Garcia <be...@igalia.com>
[GTK] [2.22.0] Fails to build in armel
Modified: trunk/Source/cmake/OptionsGTK.cmake (238538 => 238539)
--- trunk/Source/cmake/OptionsGTK.cmake 2018-11-27 01:37:22 UTC (rev 238538)
+++ trunk/Source/cmake/OptionsGTK.cmake 2018-11-27 01:54:59 UTC (rev 238539)
@@ -143,7 +143,6 @@
# Private options shared with other WebKit ports. Add options here when
# we need a value different from the default defined in WebKitFeatures.cmake.
# Changing these options is completely unsupported.
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF)
Modified: trunk/Source/cmake/OptionsWPE.cmake (238538 => 238539)
--- trunk/Source/cmake/OptionsWPE.cmake 2018-11-27 01:37:22 UTC (rev 238538)
+++ trunk/Source/cmake/OptionsWPE.cmake 2018-11-27 01:54:59 UTC (rev 238539)
@@ -30,7 +30,6 @@
# Private options shared with other WebKit ports. Add options here only if
# we need a value different from the default defined in WebKitFeatures.cmake.
# Changing these options is completely unsupported.
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MHTML PRIVATE ON)
Modified: trunk/Source/cmake/OptionsWin.cmake (238538 => 238539)
--- trunk/Source/cmake/OptionsWin.cmake 2018-11-27 01:37:22 UTC (rev 238538)
+++ trunk/Source/cmake/OptionsWin.cmake 2018-11-27 01:54:59 UTC (rev 238539)
@@ -84,7 +84,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INTL PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PUBLIC_SUFFIX_LIST PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBGL PUBLIC ON)
- WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY PRIVATE ON)
# FIXME: Implement plugin process on Modern WebKit. https://bugs.webkit.org/show_bug.cgi?id=185313
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (238538 => 238539)
--- trunk/Source/cmake/WebKitFeatures.cmake 2018-11-27 01:37:22 UTC (rev 238538)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2018-11-27 01:54:59 UTC (rev 238539)
@@ -85,7 +85,6 @@
WEBKIT_OPTION_DEFINE(ENABLE_3D_TRANSFORMS "Toggle 3D transforms support" PRIVATE ON)
WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_2D_CANVAS "Toggle accelerated 2D canvas support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_OVERFLOW_SCROLLING "Toggle accelerated scrolling support" PRIVATE OFF)
- WEBKIT_OPTION_DEFINE(ENABLE_ACCESSIBILITY "Toggle accessibility support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_API_TESTS "Enable public API unit tests" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_ASYNC_SCROLLING "Enable asynchronouse scrolling" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_ATTACHMENT_ELEMENT "Toggle attachment element support" PRIVATE OFF)
Modified: trunk/Tools/ChangeLog (238538 => 238539)
--- trunk/Tools/ChangeLog 2018-11-27 01:37:22 UTC (rev 238538)
+++ trunk/Tools/ChangeLog 2018-11-27 01:54:59 UTC (rev 238539)
@@ -1,3 +1,12 @@
+2018-11-26 Fujii Hironori <hironori.fu...@sony.com>
+
+ [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
+ https://bugs.webkit.org/show_bug.cgi?id=191831
+
+ Reviewed by Michael Catanzaro.
+
+ * WebKitTestRunner/CMakeLists.txt:
+
2018-11-26 Tim Horton <timothy_hor...@apple.com>
Insert <attachment> elements under editable images to make their backing data accessible
Modified: trunk/Tools/WebKitTestRunner/CMakeLists.txt (238538 => 238539)
--- trunk/Tools/WebKitTestRunner/CMakeLists.txt 2018-11-27 01:37:22 UTC (rev 238538)
+++ trunk/Tools/WebKitTestRunner/CMakeLists.txt 2018-11-27 01:54:59 UTC (rev 238539)
@@ -55,6 +55,10 @@
)
set(WebKitTestRunnerInjectedBundle_SOURCES
+ ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityController.cpp
+ ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarker.cpp
+ ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarkerRange.cpp
+ ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityUIElement.cpp
${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/EventSendingController.cpp
${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/GCController.cpp
${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/InjectedBundle.cpp
@@ -67,6 +71,10 @@
)
set(WebKitTestRunnerInjectedBundle_IDL_FILES
+ "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityController.idl"
+ "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarker.idl"
+ "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarkerRange.idl"
+ "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityUIElement.idl"
"${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/EventSendingController.idl"
"${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/GCController.idl"
"${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/TestRunner.idl"
@@ -73,22 +81,6 @@
"${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/TextInputController.idl"
)
-if (ENABLE_ACCESSIBILITY)
- list(APPEND WebKitTestRunnerInjectedBundle_SOURCES
- ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityController.cpp
- ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarker.cpp
- ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityTextMarkerRange.cpp
- ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/AccessibilityUIElement.cpp
- )
-
- list(APPEND WebKitTestRunnerInjectedBundle_IDL_FILES
- "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityController.idl"
- "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarker.idl"
- "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityTextMarkerRange.idl"
- "${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/Bindings/AccessibilityUIElement.idl"
- )
-endif ()
-
set(WebKitTestRunner_IDL_FILES
"${WEBKIT_TESTRUNNER_UISCRIPTCONTEXT_DIR}/Bindings/UIScriptController.idl"
)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
