Title: [238681] trunk/Source/WebKit
- Revision
- 238681
- Author
- commit-qu...@webkit.org
- Date
- 2018-11-29 11:59:43 -0800 (Thu, 29 Nov 2018)
Log Message
Addressed a FIXME by removing an unnecessary call to [NSApplication sharedApplication].
https://bugs.webkit.org/show_bug.cgi?id=192099
Patch by Suresh Koppisetty <skoppise...@apple.com> on 2018-11-29
Reviewed by Geoffrey Garen.
[NSApplication sharedApplication] call is no longer needed in platformInitializeWebProcess as [NSApplication _accessibilityInitialize] calls [NSApplication sharedApplication].
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (238680 => 238681)
--- trunk/Source/WebKit/ChangeLog 2018-11-29 19:54:40 UTC (rev 238680)
+++ trunk/Source/WebKit/ChangeLog 2018-11-29 19:59:43 UTC (rev 238681)
@@ -1,3 +1,15 @@
+2018-11-29 Suresh Koppisetty <skoppise...@apple.com>
+
+ Addressed a FIXME by removing an unnecessary call to [NSApplication sharedApplication].
+ https://bugs.webkit.org/show_bug.cgi?id=192099
+
+ Reviewed by Geoffrey Garen.
+
+ [NSApplication sharedApplication] call is no longer needed in platformInitializeWebProcess as [NSApplication _accessibilityInitialize] calls [NSApplication sharedApplication].
+
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::platformInitializeWebProcess):
+
2018-11-29 Megan Gardner <megan_gard...@apple.com>
Move Lookup Code for better cross platform usage
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (238680 => 238681)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2018-11-29 19:54:40 UTC (rev 238680)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2018-11-29 19:59:43 UTC (rev 238681)
@@ -185,8 +185,6 @@
#if PLATFORM(MAC) && ENABLE(WEBPROCESS_NSRUNLOOP)
// Need to initialize accessibility for VoiceOver to work when the WebContent process is using NSRunLoop.
// Currently, it is also needed to allocate and initialize an NSApplication object.
- // FIXME: Remove the following line when rdar://problem/36323569 is fixed.
- [NSApplication sharedApplication];
[NSApplication _accessibilityInitialize];
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
