Title: [238938] trunk/Source/WebInspectorUI
- Revision
- 238938
- Author
- mattba...@apple.com
- Date
- 2018-12-06 12:37:55 -0800 (Thu, 06 Dec 2018)
Log Message
Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work
https://bugs.webkit.org/show_bug.cgi?id=192353
<rdar://problem/46455019>
Reviewed by Devin Rousso.
* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.deselect):
Don't early return when the element is not the selected tree element.
This condition no longer holds now that TreeOutline supports multiple selection.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238937 => 238938)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-06 20:07:38 UTC (rev 238937)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-06 20:37:55 UTC (rev 238938)
@@ -1,3 +1,16 @@
+2018-12-06 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work
+ https://bugs.webkit.org/show_bug.cgi?id=192353
+ <rdar://problem/46455019>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TreeElement.js:
+ (WI.TreeElement.prototype.deselect):
+ Don't early return when the element is not the selected tree element.
+ This condition no longer holds now that TreeOutline supports multiple selection.
+
2018-12-05 Matt Baker <mattba...@apple.com>
Web Inspector: SelectionController should not extend the selection when allowsMultipleSelection is false
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js (238937 => 238938)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2018-12-06 20:07:38 UTC (rev 238937)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2018-12-06 20:37:55 UTC (rev 238938)
@@ -532,9 +532,11 @@
deselect(suppressNotification)
{
- if (!this.treeOutline || this.treeOutline.selectedTreeElement !== this || !this.selected)
+ if (!this.treeOutline || !this.selected)
return false;
+ console.assert(this.treeOutline.selectedTreeElements.includes(this));
+
this.selected = false;
this.treeOutline.selectTreeElementInternal(null, suppressNotification);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
