Title: [239292] trunk/PerformanceTests
- Revision
- 239292
- Author
- commit-qu...@webkit.org
- Date
- 2018-12-17 15:01:44 -0800 (Mon, 17 Dec 2018)
Log Message
Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
https://bugs.webkit.org/show_bug.cgi?id=192378
Patch by Suresh Koppisetty <skoppise...@apple.com> on 2018-12-17
Reviewed by Ryosuke Niwa.
FeedbackServer currently depends on Tornado-5.1, which further adds
dependency of "singledispatch", "backports-abc" and "futures" python libraries.
Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled
will let us run the benchmark scripts without installing any new python libraries.
* LaunchTime/launch_time.py:
* LaunchTime/new_tab.py:
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (239291 => 239292)
--- trunk/PerformanceTests/ChangeLog 2018-12-17 23:00:41 UTC (rev 239291)
+++ trunk/PerformanceTests/ChangeLog 2018-12-17 23:01:44 UTC (rev 239292)
@@ -1,3 +1,18 @@
+2018-12-17 Suresh Koppisetty <skoppise...@apple.com>
+
+ Import FeedbackServer only if "-f/--feedback-in-browser" option is enabled.
+ https://bugs.webkit.org/show_bug.cgi?id=192378
+
+ Reviewed by Ryosuke Niwa.
+
+ FeedbackServer currently depends on Tornado-5.1, which further adds
+ dependency of "singledispatch", "backports-abc" and "futures" python libraries.
+ Importing FeedbackServer only if "-f/--feedback-in-browser" option is enabled
+ will let us run the benchmark scripts without installing any new python libraries.
+
+ * LaunchTime/launch_time.py:
+ * LaunchTime/new_tab.py:
+
2018-12-13 Caio Lima <ticaiol...@gmail.com>
[BigInt] Add ValueDiv into DFG
Modified: trunk/PerformanceTests/LaunchTime/launch_time.py (239291 => 239292)
--- trunk/PerformanceTests/LaunchTime/launch_time.py 2018-12-17 23:00:41 UTC (rev 239291)
+++ trunk/PerformanceTests/LaunchTime/launch_time.py 2018-12-17 23:01:44 UTC (rev 239292)
@@ -10,7 +10,6 @@
import threading
import time
-from feedback_server import FeedbackServer
# Supress logs from feedback server
@@ -146,6 +145,7 @@
self._server_ready.acquire()
if self._feedback_in_browser:
+ from feedback_server import FeedbackServer
self._feedback_server = FeedbackServer()
self._feedback_port = self._feedback_server.start()
Modified: trunk/PerformanceTests/LaunchTime/new_tab.py (239291 => 239292)
--- trunk/PerformanceTests/LaunchTime/new_tab.py 2018-12-17 23:00:41 UTC (rev 239291)
+++ trunk/PerformanceTests/LaunchTime/new_tab.py 2018-12-17 23:01:44 UTC (rev 239292)
@@ -4,9 +4,7 @@
from threading import Event
from launch_time import LaunchTimeBenchmark, DefaultLaunchTimeHandler
-import feedback_server
-
class NewTabBenchmark(LaunchTimeBenchmark):
def _parse_wait_time(self, string):
values = string.split(':')
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
