Title: [239422] trunk/Source/WebInspectorUI
- Revision
- 239422
- Author
- drou...@apple.com
- Date
- 2018-12-19 20:00:01 -0800 (Wed, 19 Dec 2018)
Log Message
Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'effectiveDOMNode.enabledPseudoClasses')
https://bugs.webkit.org/show_bug.cgi?id=192783
Reviewed by Joseph Pecoraro.
* UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
(WI.GeneralStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (239421 => 239422)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-20 03:57:10 UTC (rev 239421)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-20 04:00:01 UTC (rev 239422)
@@ -1,5 +1,16 @@
2018-12-19 Devin Rousso <drou...@apple.com>
+ Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'effectiveDOMNode.enabledPseudoClasses')
+ https://bugs.webkit.org/show_bug.cgi?id=192783
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
+ (WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
+ (WI.GeneralStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):
+
+2018-12-19 Devin Rousso <drou...@apple.com>
+
Web Inspector: REGRESSION (r237195): Timelines: selecting a rendering frame row moves the time selection
https://bugs.webkit.org/show_bug.cgi?id=192773
<rdar://problem/46782446>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (239421 => 239422)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2018-12-20 03:57:10 UTC (rev 239421)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2018-12-20 04:00:01 UTC (rev 239422)
@@ -272,6 +272,8 @@
return;
let effectiveDOMNode = this.domNode.isPseudoElement() ? this.domNode.parentNode : this.domNode;
+ if (!effectiveDOMNode)
+ return;
effectiveDOMNode.setPseudoClassEnabled(pseudoClass, event.target.checked);
@@ -284,6 +286,8 @@
return;
let effectiveDOMNode = this.domNode.isPseudoElement() ? this.domNode.parentNode : this.domNode;
+ if (!effectiveDOMNode)
+ return;
let enabledPseudoClasses = effectiveDOMNode.enabledPseudoClasses;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
