Title: [239499] trunk/Source/WebDriver
- Revision
- 239499
- Author
- carlo...@webkit.org
- Date
- 2018-12-21 02:53:17 -0800 (Fri, 21 Dec 2018)
Log Message
[GLIB] WebDriver: dbusConnectionClosedCallback can be called after SessionHost has been deleted
https://bugs.webkit.org/show_bug.cgi?id=192976
Reviewed by Alejandro G. Castro.
Disconnect DBus connection signals using SessionHost as user data in SessionHost destructor.
* glib/SessionHostGlib.cpp:
(WebDriver::SessionHost::~SessionHost):
Modified Paths
Diff
Modified: trunk/Source/WebDriver/ChangeLog (239498 => 239499)
--- trunk/Source/WebDriver/ChangeLog 2018-12-21 10:34:44 UTC (rev 239498)
+++ trunk/Source/WebDriver/ChangeLog 2018-12-21 10:53:17 UTC (rev 239499)
@@ -1,3 +1,15 @@
+2018-12-21 Carlos Garcia Campos <cgar...@igalia.com>
+
+ [GLIB] WebDriver: dbusConnectionClosedCallback can be called after SessionHost has been deleted
+ https://bugs.webkit.org/show_bug.cgi?id=192976
+
+ Reviewed by Alejandro G. Castro.
+
+ Disconnect DBus connection signals using SessionHost as user data in SessionHost destructor.
+
+ * glib/SessionHostGlib.cpp:
+ (WebDriver::SessionHost::~SessionHost):
+
2018-12-20 Chris Dumez <cdu...@apple.com>
Use Optional::valueOr() instead of Optional::value_or()
Modified: trunk/Source/WebDriver/glib/SessionHostGlib.cpp (239498 => 239499)
--- trunk/Source/WebDriver/glib/SessionHostGlib.cpp 2018-12-21 10:34:44 UTC (rev 239498)
+++ trunk/Source/WebDriver/glib/SessionHostGlib.cpp 2018-12-21 10:53:17 UTC (rev 239499)
@@ -41,6 +41,8 @@
SessionHost::~SessionHost()
{
+ if (m_dbusConnection)
+ g_signal_handlers_disconnect_matched(m_dbusConnection.get(), G_SIGNAL_MATCH_DATA, 0, 0, nullptr, nullptr, this);
g_cancellable_cancel(m_cancellable.get());
if (m_browser)
g_subprocess_force_exit(m_browser.get());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
