Title: [239527] trunk/Source/WebInspectorUI
- Revision
- 239527
- Author
- nvasil...@apple.com
- Date
- 2018-12-21 16:16:20 -0800 (Fri, 21 Dec 2018)
Log Message
Web Inspector: Styles: editing focus lost when inspector is blurred
https://bugs.webkit.org/show_bug.cgi?id=192123
<rdar://problem/46800966>
Reviewed by Devin Rousso.
* UserInterface/Views/SpreadsheetSelectorField.js:
(WI.SpreadsheetSelectorField.prototype._handleBlur):
* UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype._handleBlur):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (239526 => 239527)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-22 00:02:19 UTC (rev 239526)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-22 00:16:20 UTC (rev 239527)
@@ -1,3 +1,16 @@
+2018-12-21 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Styles: editing focus lost when inspector is blurred
+ https://bugs.webkit.org/show_bug.cgi?id=192123
+ <rdar://problem/46800966>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/SpreadsheetSelectorField.js:
+ (WI.SpreadsheetSelectorField.prototype._handleBlur):
+ * UserInterface/Views/SpreadsheetTextField.js:
+ (WI.SpreadsheetTextField.prototype._handleBlur):
+
2018-12-21 Devin Rousso <drou...@apple.com>
Web Inspector: Settings: experimental setting editors are misaligned in other locales
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js (239526 => 239527)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js 2018-12-22 00:02:19 UTC (rev 239526)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetSelectorField.js 2018-12-22 00:16:20 UTC (rev 239527)
@@ -85,6 +85,10 @@
_handleBlur(event)
{
+ // Keep editing after tabbing out of Web Inspector window and back.
+ if (document.activeElement === this._element)
+ return;
+
this.stopEditing();
if (this._delegate && typeof this._delegate.spreadsheetSelectorFieldDidChange === "function")
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js (239526 => 239527)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-12-22 00:02:19 UTC (rev 239526)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js 2018-12-22 00:16:20 UTC (rev 239527)
@@ -213,6 +213,10 @@
if (!this._editing)
return;
+ // Keep editing after tabbing out of Web Inspector window and back.
+ if (document.activeElement === this._element)
+ return;
+
this._applyCompletionHint();
this.discardCompletion();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
