Title: [239728] trunk/Source/WebKit
- Revision
- 239728
- Author
- commit-qu...@webkit.org
- Date
- 2019-01-08 10:13:16 -0800 (Tue, 08 Jan 2019)
Log Message
[GTK][WPE] Remove DConf permissions from sandbox
https://bugs.webkit.org/show_bug.cgi?id=193021
Patch by Patrick Griffis <pgrif...@igalia.com> on 2019-01-08
Reviewed by Michael Catanzaro.
The latest development releases of xdg-desktop-portal and gtk3 use a
new portal for settings on Wayland org.freedesktop.portal.Settings.
* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bubblewrapSpawn):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239727 => 239728)
--- trunk/Source/WebKit/ChangeLog 2019-01-08 18:08:55 UTC (rev 239727)
+++ trunk/Source/WebKit/ChangeLog 2019-01-08 18:13:16 UTC (rev 239728)
@@ -1,3 +1,16 @@
+2019-01-08 Patrick Griffis <pgrif...@igalia.com>
+
+ [GTK][WPE] Remove DConf permissions from sandbox
+ https://bugs.webkit.org/show_bug.cgi?id=193021
+
+ Reviewed by Michael Catanzaro.
+
+ The latest development releases of xdg-desktop-portal and gtk3 use a
+ new portal for settings on Wayland org.freedesktop.portal.Settings.
+
+ * UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+ (WebKit::bubblewrapSpawn):
+
2019-01-08 Alex Christensen <achristen...@webkit.org>
Stop using NetworkStorageSession in WebProcess
Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (239727 => 239728)
--- trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp 2019-01-08 18:08:55 UTC (rev 239727)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp 2019-01-08 18:13:16 UTC (rev 239728)
@@ -308,22 +308,6 @@
bindIfExists(args, xauth);
}
-static void bindDconf(Vector<CString>& args)
-{
- const char* runtimeDir = g_get_user_runtime_dir();
- GUniquePtr<char> dconfRuntimeDir(g_build_filename(runtimeDir, "dconf", nullptr));
- args.appendVector(Vector<CString>({ "--bind", dconfRuntimeDir.get(), dconfRuntimeDir.get() }));
-
- const char* dconfDir = g_getenv("DCONF_USER_CONFIG_DIR");
- if (dconfDir)
- bindIfExists(args, dconfDir);
- else {
- const char* configDir = g_get_user_config_dir();
- GUniquePtr<char> dconfConfigDir(g_build_filename(configDir, "dconf", nullptr));
- bindIfExists(args, dconfConfigDir.get(), BindFlags::ReadWrite);
- }
-}
-
#if PLATFORM(WAYLAND) && USE(EGL)
static void bindWayland(Vector<CString>& args)
{
@@ -795,8 +779,6 @@
}
bindDBusSession(sandboxArgs, proxy);
- // FIXME: This needs to be restricted, upstream is working on it.
- bindDconf(sandboxArgs);
// FIXME: We should move to Pipewire as soon as viable, Pulse doesn't restrict clients atm.
bindPulse(sandboxArgs);
bindFonts(sandboxArgs);
@@ -811,8 +793,6 @@
if (!proxy.isRunning()) {
Vector<CString> permissions = {
- // FIXME: Used by GTK on Wayland.
- "--talk=ca.desrt.dconf",
// GStreamers plugin install helper.
"--call=org.freedesktop.PackageKit=org.freedesktop.PackageKit.Modify2.InstallGStreamerResources@/org/freedesktop/PackageKit"
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
