Title: [239738] trunk/Source/WebKit
- Revision
- 239738
- Author
- achristen...@apple.com
- Date
- 2019-01-08 13:05:24 -0800 (Tue, 08 Jan 2019)
Log Message
Call CompletionHandler when destroying a NetworkCache::Storage::WriteOperation
https://bugs.webkit.org/show_bug.cgi?id=193251
Reviewed by Chris Dumez.
This fixes another assertion introduced in r239710.
* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::WriteOperation::~WriteOperation):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239737 => 239738)
--- trunk/Source/WebKit/ChangeLog 2019-01-08 20:49:39 UTC (rev 239737)
+++ trunk/Source/WebKit/ChangeLog 2019-01-08 21:05:24 UTC (rev 239738)
@@ -1,5 +1,17 @@
2019-01-08 Alex Christensen <achristen...@webkit.org>
+ Call CompletionHandler when destroying a NetworkCache::Storage::WriteOperation
+ https://bugs.webkit.org/show_bug.cgi?id=193251
+
+ Reviewed by Chris Dumez.
+
+ This fixes another assertion introduced in r239710.
+
+ * NetworkProcess/cache/NetworkCacheStorage.cpp:
+ (WebKit::NetworkCache::Storage::WriteOperation::~WriteOperation):
+
+2019-01-08 Alex Christensen <achristen...@webkit.org>
+
Stop using NetworkStorageSession in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=193236
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp (239737 => 239738)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp 2019-01-08 20:49:39 UTC (rev 239737)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp 2019-01-08 21:05:24 UTC (rev 239738)
@@ -112,6 +112,13 @@
, mappedBodyHandler(WTFMove(mappedBodyHandler))
, completionHandler(WTFMove(completionHandler))
{ }
+
+ ~WriteOperation()
+ {
+ if (completionHandler)
+ completionHandler(0);
+ }
+
Ref<Storage> storage;
const Record record;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
