Title: [240051] trunk/Source/WebInspectorUI
Revision
240051
Author
mattba...@apple.com
Date
2019-01-16 14:04:35 -0800 (Wed, 16 Jan 2019)

Log Message

Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
https://bugs.webkit.org/show_bug.cgi?id=193501
<rdar://problem/47323967>

Reviewed by Joseph Pecoraro.

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.removeChildAtIndex):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (240050 => 240051)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-01-16 21:06:45 UTC (rev 240050)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-01-16 22:04:35 UTC (rev 240051)
@@ -1,3 +1,14 @@
+2019-01-16  Matt Baker  <mattba...@apple.com>
+
+        Web Inspector: Fix TreeOutline TypeError:​ this._indexesForSubtree is not a function
+        https://bugs.webkit.org/show_bug.cgi?id=193501
+        <rdar://problem/47323967>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype.removeChildAtIndex):
+
 2019-01-15  Devin Rousso  <drou...@apple.com>
 
         Web Inspector: Audit: create new IDL type for exposing special functionality in test context

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (240050 => 240051)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js	2019-01-16 21:06:45 UTC (rev 240050)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js	2019-01-16 22:04:35 UTC (rev 240051)
@@ -323,14 +323,15 @@
                 parent.select(true, false);
         }
 
+        let removedIndexes = null;
+
         let treeOutline = child.treeOutline;
         if (treeOutline) {
             treeOutline._forgetTreeElement(child);
             treeOutline._forgetChildrenRecursive(child);
+            removedIndexes = treeOutline._indexesForSubtree(child);
         }
 
-        let removedIndexes = this._indexesForSubtree(child);
-
         if (child.previousSibling)
             child.previousSibling.nextSibling = child.nextSibling;
         if (child.nextSibling)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to