Title: [240799] trunk/Source/WebCore
- Revision
- 240799
- Author
- krol...@apple.com
- Date
- 2019-01-31 11:29:27 -0800 (Thu, 31 Jan 2019)
Log Message
GCGamepad is deprecated
https://bugs.webkit.org/show_bug.cgi?id=194056
<rdar://problem/47685010>
Reviewed by Brady Eidson.
GCGamepad is deprecated, resulting in compiler warnings. Address this
for now by employing ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
No new tests since there should be no observable behavior difference.
* platform/gamepad/cocoa/GameControllerGamepad.mm:
(WebCore::GameControllerGamepad::setupAsGamepad):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240798 => 240799)
--- trunk/Source/WebCore/ChangeLog 2019-01-31 19:14:58 UTC (rev 240798)
+++ trunk/Source/WebCore/ChangeLog 2019-01-31 19:29:27 UTC (rev 240799)
@@ -1,3 +1,19 @@
+2019-01-31 Keith Rollin <krol...@apple.com>
+
+ GCGamepad is deprecated
+ https://bugs.webkit.org/show_bug.cgi?id=194056
+ <rdar://problem/47685010>
+
+ Reviewed by Brady Eidson.
+
+ GCGamepad is deprecated, resulting in compiler warnings. Address this
+ for now by employing ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END.
+
+ No new tests since there should be no observable behavior difference.
+
+ * platform/gamepad/cocoa/GameControllerGamepad.mm:
+ (WebCore::GameControllerGamepad::setupAsGamepad):
+
2019-01-31 Darin Adler <da...@apple.com>
Simplify and streamline code that creates an appropriate document based on MIME type
Modified: trunk/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm (240798 => 240799)
--- trunk/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm 2019-01-31 19:14:58 UTC (rev 240798)
+++ trunk/Source/WebCore/platform/gamepad/cocoa/GameControllerGamepad.mm 2019-01-31 19:29:27 UTC (rev 240799)
@@ -147,11 +147,13 @@
m_id = makeString(String(m_gcController.get().vendorName), " Gamepad"_s);
+ ALLOW_DEPRECATED_DECLARATIONS_BEGIN // GCGamepad
m_gamepad.get().valueChangedHandler = ^(GCGamepad *, GCControllerElement *) {
m_lastUpdateTime = MonotonicTime::now();
GameControllerGamepadProvider::singleton().gamepadHadInput(*this, m_hadButtonPresses);
m_hadButtonPresses = false;
};
+ ALLOW_DEPRECATED_DECLARATIONS_END
m_buttonValues.resize(6);
m_buttonValues[0] = m_extendedGamepad.get().buttonA.value;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
