Log Message
WebCore::WHLSL::AST::_expression_ copy constructor needs to be be default, not delete https://bugs.webkit.org/show_bug.cgi?id=194055 <rdar://problem/47684570>
Reviewed by Myles C. Maxfield. WebCore::WHLSL::AST::_expression_ has a deleted copy constructor. EnumerationMemberLiteral, a subclass, has a default copy constructor. Some compilers may complain that the latter's c'tor can't access the former's, because it doesn't exist. Fix this by marking _expression_'s c'tor as default. No new tests since there should be no observable behavior difference. * Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (240815 => 240816)
--- trunk/Source/WebCore/ChangeLog 2019-01-31 21:55:44 UTC (rev 240815)
+++ trunk/Source/WebCore/ChangeLog 2019-01-31 22:11:32 UTC (rev 240816)
@@ -1,3 +1,21 @@
+2019-01-31 Keith Rollin <krol...@apple.com>
+
+ WebCore::WHLSL::AST::_expression_ copy constructor needs to be be default, not delete
+ https://bugs.webkit.org/show_bug.cgi?id=194055
+ <rdar://problem/47684570>
+
+ Reviewed by Myles C. Maxfield.
+
+ WebCore::WHLSL::AST::_expression_ has a deleted copy constructor.
+ EnumerationMemberLiteral, a subclass, has a default copy constructor.
+ Some compilers may complain that the latter's c'tor can't access the
+ former's, because it doesn't exist. Fix this by marking _expression_'s
+ c'tor as default.
+
+ No new tests since there should be no observable behavior difference.
+
+ * Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
+
2019-01-31 Alex Christensen <achristen...@webkit.org>
Revert r238819 which is unneeded and caused a performance regression.
Modified: trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h (240815 => 240816)
--- trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h 2019-01-31 21:55:44 UTC (rev 240815)
+++ trunk/Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLExpression.h 2019-01-31 22:11:32 UTC (rev 240816)
@@ -49,7 +49,7 @@
virtual ~_expression_() = default;
- _expression_(const _expression_&) = delete;
+ _expression_(const _expression_&) = default;
_expression_(_expression_&&) = default;
_expression_& operator=(const _expression_&) = default;
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
