Title: [240817] trunk/LayoutTests
- Revision
- 240817
- Author
- cdu...@apple.com
- Date
- 2019-01-31 14:13:53 -0800 (Thu, 31 Jan 2019)
Log Message
[ MacOS ] Layout Test performance-api/performance-observer-callback-after-gc.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=191041
<rdar://problem/45649982>
Reviewed by Joseph Pecoraro.
Make the test print the same output no matter if the performance observer is notified once or
twice. What matters is that it is notified about 3 marks.
* performance-api/performance-observer-callback-after-gc-expected.txt:
* performance-api/performance-observer-callback-after-gc.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (240816 => 240817)
--- trunk/LayoutTests/ChangeLog 2019-01-31 22:11:32 UTC (rev 240816)
+++ trunk/LayoutTests/ChangeLog 2019-01-31 22:13:53 UTC (rev 240817)
@@ -1,3 +1,17 @@
+2019-01-31 Chris Dumez <cdu...@apple.com>
+
+ [ MacOS ] Layout Test performance-api/performance-observer-callback-after-gc.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=191041
+ <rdar://problem/45649982>
+
+ Reviewed by Joseph Pecoraro.
+
+ Make the test print the same output no matter if the performance observer is notified once or
+ twice. What matters is that it is notified about 3 marks.
+
+ * performance-api/performance-observer-callback-after-gc-expected.txt:
+ * performance-api/performance-observer-callback-after-gc.html:
+
2019-01-31 Justin Fan <justin_...@apple.com>
[WebGPU] WebGPUAdapterDescriptor -> GPURequestAdapterOptions and take powerPreference into account
Modified: trunk/LayoutTests/performance-api/performance-observer-callback-after-gc-expected.txt (240816 => 240817)
--- trunk/LayoutTests/performance-api/performance-observer-callback-after-gc-expected.txt 2019-01-31 22:11:32 UTC (rev 240816)
+++ trunk/LayoutTests/performance-api/performance-observer-callback-after-gc-expected.txt 2019-01-31 22:13:53 UTC (rev 240817)
@@ -3,9 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PerformanceObserver callback fired: 1 entries
PASS mark1
-PerformanceObserver callback fired: 2 entries
PASS mark2
PASS mark3
PASS successfullyParsed is true
Modified: trunk/LayoutTests/performance-api/performance-observer-callback-after-gc.html (240816 => 240817)
--- trunk/LayoutTests/performance-api/performance-observer-callback-after-gc.html 2019-01-31 22:11:32 UTC (rev 240816)
+++ trunk/LayoutTests/performance-api/performance-observer-callback-after-gc.html 2019-01-31 22:13:53 UTC (rev 240817)
@@ -8,14 +8,17 @@
description("Ensure PerformanceObserver callback fires even if the JS does not keep the PerformanceObserver object alive.");
window.jsTestIsAsync = true;
-let shouldEnd = false;
+let receivedEntries = [];
let observer = new PerformanceObserver((list) => {
- debug("PerformanceObserver callback fired: " + list.getEntries().length + " entries");
for (let mark of list.getEntries())
- testPassed(mark.name);
- if (shouldEnd)
- finishJSTest();
+ receivedEntries.push(mark.name);
+
+ if (receivedEntries.length == 3) {
+ for (let name of receivedEntries)
+ testPassed(name);
+ finishJSTest();
+ }
});
observer.observe({entryTypes: ["mark"]});
observer = null;
@@ -29,7 +32,6 @@
gc();
performance.mark("mark2");
performance.mark("mark3");
- shouldEnd = true;
}, 50);
</script>
<script src=""
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
