Title: [240950] trunk/Source/WebInspectorUI
- Revision
- 240950
- Author
- mattba...@apple.com
- Date
- 2019-02-04 17:08:40 -0800 (Mon, 04 Feb 2019)
Log Message
Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the page
https://bugs.webkit.org/show_bug.cgi?id=194242
<rdar://problem/47802027>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/FolderizedTreeElement.js:
(WI.FolderizedTreeElement.prototype.removeChildren):
FolderTreeElements are removed by the base class call to removeChildren.
Calling `removeChildren` for detached TreeElements is unnecessary.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240949 => 240950)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 00:47:17 UTC (rev 240949)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 01:08:40 UTC (rev 240950)
@@ -1,5 +1,18 @@
2019-02-04 Matt Baker <mattba...@apple.com>
+ Web Inspector: REGRESSION: Resources: WI.TreeOutline assertions when refreshing the page
+ https://bugs.webkit.org/show_bug.cgi?id=194242
+ <rdar://problem/47802027>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/FolderizedTreeElement.js:
+ (WI.FolderizedTreeElement.prototype.removeChildren):
+ FolderTreeElements are removed by the base class call to removeChildren.
+ Calling `removeChildren` for detached TreeElements is unnecessary.
+
+2019-02-04 Matt Baker <mattba...@apple.com>
+
Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
https://bugs.webkit.org/show_bug.cgi?id=194169
<rdar://problem/47743864>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js (240949 => 240950)
--- trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js 2019-02-05 00:47:17 UTC (rev 240949)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FolderizedTreeElement.js 2019-02-05 01:08:40 UTC (rev 240950)
@@ -69,8 +69,6 @@
this._folderizeSettingsMap.set(type, settings);
}
- // Overrides from TreeElement (Private).
-
removeChildren()
{
super.removeChildren();
@@ -77,9 +75,6 @@
this._clearNewChildQueue();
- for (var folder of this._folderTypeMap.values())
- folder.removeChildren();
-
this._folderExpandedSettingMap.clear();
this._folderTypeMap.clear();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
