Diff
Modified: trunk/Source/WebKit/ChangeLog (240954 => 240955)
--- trunk/Source/WebKit/ChangeLog 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/ChangeLog 2019-02-05 01:30:24 UTC (rev 240955)
@@ -1,3 +1,92 @@
+2019-02-04 Alex Christensen <achristen...@webkit.org>
+
+ Make MessageSender functions const
+ https://bugs.webkit.org/show_bug.cgi?id=194247
+
+ Reviewed by Brady Eidson.
+
+ * NetworkProcess/Downloads/Download.cpp:
+ (WebKit::Download::messageSenderConnection const):
+ (WebKit::Download::messageSenderDestinationID const):
+ (WebKit::Download::messageSenderConnection): Deleted.
+ (WebKit::Download::messageSenderDestinationID): Deleted.
+ * NetworkProcess/Downloads/Download.h:
+ * NetworkProcess/Downloads/PendingDownload.cpp:
+ (WebKit::PendingDownload::messageSenderConnection const):
+ (WebKit::PendingDownload::messageSenderDestinationID const):
+ (WebKit::PendingDownload::messageSenderConnection): Deleted.
+ (WebKit::PendingDownload::messageSenderDestinationID): Deleted.
+ * NetworkProcess/Downloads/PendingDownload.h:
+ * NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:
+ (WebKit::WebIDBConnectionToClient::messageSenderConnection const):
+ (WebKit::WebIDBConnectionToClient::messageSenderConnection): Deleted.
+ * NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::NetworkResourceLoader::messageSenderConnection const):
+ (WebKit::NetworkResourceLoader::messageSenderConnection): Deleted.
+ * NetworkProcess/NetworkResourceLoader.h:
+ * NetworkProcess/NetworkSocketStream.cpp:
+ (WebKit::NetworkSocketStream::messageSenderConnection const):
+ (WebKit::NetworkSocketStream::messageSenderDestinationID const):
+ (WebKit::NetworkSocketStream::messageSenderConnection): Deleted.
+ (WebKit::NetworkSocketStream::messageSenderDestinationID): Deleted.
+ * NetworkProcess/NetworkSocketStream.h:
+ * NetworkProcess/ServiceWorker/WebSWServerConnection.h:
+ * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
+ (WebKit::WebSWServerToContextConnection::messageSenderConnection const):
+ (WebKit::WebSWServerToContextConnection::messageSenderDestinationID const):
+ (WebKit::WebSWServerToContextConnection::messageSenderConnection): Deleted.
+ (WebKit::WebSWServerToContextConnection::messageSenderDestinationID): Deleted.
+ * NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
+ * Platform/IPC/MessageSender.h:
+ * Shared/AuxiliaryProcess.cpp:
+ (WebKit::AuxiliaryProcess::messageSenderConnection const):
+ (WebKit::AuxiliaryProcess::messageSenderDestinationID const):
+ (WebKit::AuxiliaryProcess::messageSenderConnection): Deleted.
+ (WebKit::AuxiliaryProcess::messageSenderDestinationID): Deleted.
+ * Shared/AuxiliaryProcess.h:
+ * UIProcess/WebConnectionToWebProcess.cpp:
+ (WebKit::WebConnectionToWebProcess::messageSenderConnection const):
+ (WebKit::WebConnectionToWebProcess::messageSenderDestinationID const):
+ (WebKit::WebConnectionToWebProcess::messageSenderConnection): Deleted.
+ (WebKit::WebConnectionToWebProcess::messageSenderDestinationID): Deleted.
+ * UIProcess/WebConnectionToWebProcess.h:
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::messageSenderConnection const):
+ (WebKit::WebPageProxy::messageSenderDestinationID const):
+ (WebKit::WebPageProxy::messageSenderConnection): Deleted.
+ (WebKit::WebPageProxy::messageSenderDestinationID): Deleted.
+ * UIProcess/WebPageProxy.h:
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
+ (WebKit::WebIDBConnectionToServer::messageSenderConnection const):
+ (WebKit::WebIDBConnectionToServer::messageSenderConnection): Deleted.
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
+ * WebProcess/Network/WebResourceLoader.cpp:
+ (WebKit::WebResourceLoader::messageSenderConnection const):
+ (WebKit::WebResourceLoader::messageSenderDestinationID const):
+ (WebKit::WebResourceLoader::messageSenderConnection): Deleted.
+ (WebKit::WebResourceLoader::messageSenderDestinationID): Deleted.
+ * WebProcess/Network/WebResourceLoader.h:
+ * WebProcess/Network/WebSocketStream.cpp:
+ (WebKit::WebSocketStream::messageSenderConnection const):
+ (WebKit::WebSocketStream::messageSenderDestinationID const):
+ (WebKit::WebSocketStream::messageSenderConnection): Deleted.
+ (WebKit::WebSocketStream::messageSenderDestinationID): Deleted.
+ * WebProcess/Network/WebSocketStream.h:
+ * WebProcess/Storage/WebSWClientConnection.h:
+ * WebProcess/WebConnectionToUIProcess.cpp:
+ (WebKit::WebConnectionToUIProcess::messageSenderConnection const):
+ (WebKit::WebConnectionToUIProcess::messageSenderDestinationID const):
+ (WebKit::WebConnectionToUIProcess::messageSenderConnection): Deleted.
+ (WebKit::WebConnectionToUIProcess::messageSenderDestinationID): Deleted.
+ * WebProcess/WebConnectionToUIProcess.h:
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::messageSenderConnection const):
+ (WebKit::WebPage::messageSenderDestinationID const):
+ (WebKit::WebPage::messageSenderConnection): Deleted.
+ (WebKit::WebPage::messageSenderDestinationID): Deleted.
+ * WebProcess/WebPage/WebPage.h:
+
2019-02-04 Brady Eidson <beid...@apple.com>
Take additional process assertion while downloading.
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/Download.cpp (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/Downloads/Download.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/Download.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -159,12 +159,12 @@
m_downloadManager.downloadFinished(this);
}
-IPC::Connection* Download::messageSenderConnection()
+IPC::Connection* Download::messageSenderConnection() const
{
return m_downloadManager.downloadProxyConnection();
}
-uint64_t Download::messageSenderDestinationID()
+uint64_t Download::messageSenderDestinationID() const
{
return m_downloadID.downloadID();
}
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/Download.h (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/Downloads/Download.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/Download.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -91,8 +91,8 @@
private:
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
void platformCancelNetworkLoad();
void platformDestroyDownload();
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -98,7 +98,7 @@
send(Messages::DownloadProxy::DidFail(error, { }));
}
-IPC::Connection* PendingDownload::messageSenderConnection()
+IPC::Connection* PendingDownload::messageSenderConnection() const
{
return m_parentProcessConnection.get();
}
@@ -108,7 +108,7 @@
completionHandler(WebCore::PolicyAction::Download);
}
-uint64_t PendingDownload::messageSenderDestinationID()
+uint64_t PendingDownload::messageSenderDestinationID() const
{
return m_networkLoad->pendingDownloadID().downloadID();
}
Modified: trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.h (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/Downloads/PendingDownload.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -71,8 +71,8 @@
void didFailLoading(const WebCore::ResourceError&) override;
// MessageSender.
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
private:
std::unique_ptr<NetworkLoad> m_networkLoad;
Modified: trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -69,7 +69,7 @@
m_networkProcess->idbServer(m_sessionID).unregisterConnection(*m_connectionToClient);
}
-IPC::Connection* WebIDBConnectionToClient::messageSenderConnection()
+IPC::Connection* WebIDBConnectionToClient::messageSenderConnection() const
{
return m_connection.ptr();
}
Modified: trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -60,7 +60,7 @@
WebCore::IDBServer::IDBConnectionToClient& connectionToClient();
uint64_t identifier() const final { return m_identifier; }
- uint64_t messageSenderDestinationID() final { return m_identifier; }
+ uint64_t messageSenderDestinationID() const final { return m_identifier; }
// IDBConnectionToClientDelegate
void didDeleteDatabase(const WebCore::IDBResultData&) final;
@@ -130,7 +130,7 @@
private:
WebIDBConnectionToClient(NetworkProcess&, IPC::Connection&, uint64_t serverConnectionIdentifier, PAL::SessionID);
- IPC::Connection* messageSenderConnection() final;
+ IPC::Connection* messageSenderConnection() const final;
template<class MessageType> void handleGetResult(const WebCore::IDBResultData&);
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -898,7 +898,7 @@
willSendRedirectedRequest(WTFMove(request), ResourceRequest { *entry->redirectRequest() }, ResourceResponse { entry->response() });
}
-IPC::Connection* NetworkResourceLoader::messageSenderConnection()
+IPC::Connection* NetworkResourceLoader::messageSenderConnection() const
{
return &connectionToWebProcess().connection();
}
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -81,7 +81,7 @@
const WebCore::ResourceResponse& response() const { return m_response; }
- NetworkConnectionToWebProcess& connectionToWebProcess() { return m_connection; }
+ NetworkConnectionToWebProcess& connectionToWebProcess() const { return m_connection; }
PAL::SessionID sessionID() const { return m_parameters.sessionID; }
ResourceLoadIdentifier identifier() const { return m_parameters.identifier; }
uint64_t frameID() const { return m_parameters.webFrameID; }
@@ -119,8 +119,8 @@
NetworkResourceLoader(NetworkResourceLoadParameters&&, NetworkConnectionToWebProcess&, Messages::NetworkConnectionToWebProcess::PerformSynchronousLoad::DelayedReply&&);
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override { return m_parameters.identifier; }
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override { return m_parameters.identifier; }
bool canUseCache(const WebCore::ResourceRequest&) const;
bool canUseCachedRedirect(const WebCore::ResourceRequest&) const;
Modified: trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.cpp (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -107,12 +107,12 @@
send(Messages::WebSocketStream::DidFailSocketStream(error));
}
-IPC::Connection* NetworkSocketStream::messageSenderConnection()
+IPC::Connection* NetworkSocketStream::messageSenderConnection() const
{
return &m_connection;
}
-uint64_t NetworkSocketStream::messageSenderDestinationID()
+uint64_t NetworkSocketStream::messageSenderDestinationID() const
{
return m_identifier;
}
Modified: trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.h (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -61,8 +61,8 @@
void didFailSocketStream(WebCore::SocketStreamHandle&, const WebCore::SocketStreamError&) final;
private:
- IPC::Connection* messageSenderConnection() final;
- uint64_t messageSenderDestinationID() final;
+ IPC::Connection* messageSenderConnection() const final;
+ uint64_t messageSenderDestinationID() const final;
NetworkSocketStream(NetworkProcess&, URL&&, PAL::SessionID, const String& credentialPartition, uint64_t, IPC::Connection&, WebCore::SourceApplicationAuditToken&&);
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -98,8 +98,8 @@
void registerServiceWorkerClient(WebCore::SecurityOriginData&& topOrigin, WebCore::ServiceWorkerClientData&&, const Optional<WebCore::ServiceWorkerRegistrationIdentifier>&, String&& userAgent);
void unregisterServiceWorkerClient(const WebCore::ServiceWorkerClientIdentifier&);
- IPC::Connection* messageSenderConnection() final { return m_contentConnection.ptr(); }
- uint64_t messageSenderDestinationID() final { return identifier().toUInt64(); }
+ IPC::Connection* messageSenderConnection() const final { return m_contentConnection.ptr(); }
+ uint64_t messageSenderDestinationID() const final { return identifier().toUInt64(); }
template<typename U> static void sendToContextProcess(WebCore::SWServerToContextConnection&, U&& message);
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -45,12 +45,12 @@
WebSWServerToContextConnection::~WebSWServerToContextConnection() = default;
-IPC::Connection* WebSWServerToContextConnection::messageSenderConnection()
+IPC::Connection* WebSWServerToContextConnection::messageSenderConnection() const
{
return m_ipcConnection.ptr();
}
-uint64_t WebSWServerToContextConnection::messageSenderDestinationID()
+uint64_t WebSWServerToContextConnection::messageSenderDestinationID() const
{
return 0;
}
Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h (240954 => 240955)
--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -56,8 +56,8 @@
~WebSWServerToContextConnection();
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() final;
- uint64_t messageSenderDestinationID() final;
+ IPC::Connection* messageSenderConnection() const final;
+ uint64_t messageSenderDestinationID() const final;
// Messages to the SW host WebProcess
void installServiceWorkerContext(const WebCore::ServiceWorkerContextData&, PAL::SessionID, const String& userAgent) final;
Modified: trunk/Source/WebKit/Platform/IPC/MessageSender.h (240954 => 240955)
--- trunk/Source/WebKit/Platform/IPC/MessageSender.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/Platform/IPC/MessageSender.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -74,8 +74,8 @@
virtual bool sendMessage(std::unique_ptr<Encoder>, OptionSet<SendOption>);
private:
- virtual Connection* messageSenderConnection() = 0;
- virtual uint64_t messageSenderDestinationID() = 0;
+ virtual Connection* messageSenderConnection() const = 0;
+ virtual uint64_t messageSenderDestinationID() const = 0;
};
} // namespace IPC
Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp (240954 => 240955)
--- trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -150,12 +150,12 @@
m_terminationTimer.startOneShot(m_terminationTimeout);
}
-IPC::Connection* AuxiliaryProcess::messageSenderConnection()
+IPC::Connection* AuxiliaryProcess::messageSenderConnection() const
{
return m_connection.get();
}
-uint64_t AuxiliaryProcess::messageSenderDestinationID()
+uint64_t AuxiliaryProcess::messageSenderDestinationID() const
{
return 0;
}
Modified: trunk/Source/WebKit/Shared/AuxiliaryProcess.h (240954 => 240955)
--- trunk/Source/WebKit/Shared/AuxiliaryProcess.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/Shared/AuxiliaryProcess.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -114,8 +114,8 @@
virtual bool shouldOverrideQuarantine() { return true; }
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
// IPC::Connection::Client.
void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference messageReceiverName, IPC::StringReference messageName) final;
Modified: trunk/Source/WebKit/UIProcess/WebConnectionToWebProcess.cpp (240954 => 240955)
--- trunk/Source/WebKit/UIProcess/WebConnectionToWebProcess.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/UIProcess/WebConnectionToWebProcess.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -66,12 +66,12 @@
return m_process;
}
-IPC::Connection* WebConnectionToWebProcess::messageSenderConnection()
+IPC::Connection* WebConnectionToWebProcess::messageSenderConnection() const
{
return m_process->connection();
}
-uint64_t WebConnectionToWebProcess::messageSenderDestinationID()
+uint64_t WebConnectionToWebProcess::messageSenderDestinationID() const
{
return 0;
}
Modified: trunk/Source/WebKit/UIProcess/WebConnectionToWebProcess.h (240954 => 240955)
--- trunk/Source/WebKit/UIProcess/WebConnectionToWebProcess.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/UIProcess/WebConnectionToWebProcess.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -48,8 +48,8 @@
bool hasValidConnection() const override;
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
WebProcessProxy* m_process;
};
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (240954 => 240955)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -5580,12 +5580,12 @@
return m_process->sendMessage(WTFMove(encoder), sendOptions);
}
-IPC::Connection* WebPageProxy::messageSenderConnection()
+IPC::Connection* WebPageProxy::messageSenderConnection() const
{
return m_process->connection();
}
-uint64_t WebPageProxy::messageSenderDestinationID()
+uint64_t WebPageProxy::messageSenderDestinationID() const
{
return m_pageID;
}
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (240954 => 240955)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -1479,8 +1479,8 @@
// IPC::MessageSender
bool sendMessage(std::unique_ptr<IPC::Encoder>, OptionSet<IPC::SendOption>) override;
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
// WebPopupMenuProxy::Client
void valueChangedForPopupMenu(WebPopupMenuProxy*, int32_t newSelectedIndex) override;
Modified: trunk/Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -71,7 +71,7 @@
{
}
-IPC::Connection* WebIDBConnectionToServer::messageSenderConnection()
+IPC::Connection* WebIDBConnectionToServer::messageSenderConnection() const
{
return &WebProcess::singleton().ensureNetworkProcessConnection().connection();
}
Modified: trunk/Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -44,7 +44,7 @@
WebCore::IDBClient::IDBConnectionToServer& coreConnectionToServer();
uint64_t identifier() const final { return m_identifier; }
- uint64_t messageSenderDestinationID() final { return m_identifier; }
+ uint64_t messageSenderDestinationID() const final { return m_identifier; }
// IDBConnectionToServerDelegate
void deleteDatabase(const WebCore::IDBRequestData&) final;
@@ -111,7 +111,7 @@
private:
WebIDBConnectionToServer(PAL::SessionID);
- IPC::Connection* messageSenderConnection() final;
+ IPC::Connection* messageSenderConnection() const final;
uint64_t m_identifier { 0 };
bool m_isOpenInServer { false };
Modified: trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -65,12 +65,12 @@
{
}
-IPC::Connection* WebResourceLoader::messageSenderConnection()
+IPC::Connection* WebResourceLoader::messageSenderConnection() const
{
return &WebProcess::singleton().ensureNetworkProcessConnection().connection();
}
-uint64_t WebResourceLoader::messageSenderDestinationID()
+uint64_t WebResourceLoader::messageSenderDestinationID() const
{
RELEASE_ASSERT(RunLoop::isMain());
RELEASE_ASSERT(m_coreLoader->identifier());
Modified: trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.h (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -71,8 +71,8 @@
WebResourceLoader(Ref<WebCore::ResourceLoader>&&, const TrackingParameters&);
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
void willSendRequest(WebCore::ResourceRequest&&, WebCore::ResourceResponse&&);
void didSendData(uint64_t bytesSent, uint64_t totalBytesToBeSent);
Modified: trunk/Source/WebKit/WebProcess/Network/WebSocketStream.cpp (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/Network/WebSocketStream.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/Network/WebSocketStream.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -86,12 +86,12 @@
globalWebSocketStreamMap().remove(identifier());
}
-IPC::Connection* WebSocketStream::messageSenderConnection()
+IPC::Connection* WebSocketStream::messageSenderConnection() const
{
return &WebProcess::singleton().ensureNetworkProcessConnection().connection();
}
-uint64_t WebSocketStream::messageSenderDestinationID()
+uint64_t WebSocketStream::messageSenderDestinationID() const
{
return identifier();
}
Modified: trunk/Source/WebKit/WebProcess/Network/WebSocketStream.h (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/Network/WebSocketStream.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/Network/WebSocketStream.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -70,8 +70,8 @@
private:
// MessageSender
- IPC::Connection* messageSenderConnection() final;
- uint64_t messageSenderDestinationID() final;
+ IPC::Connection* messageSenderConnection() const final;
+ uint64_t messageSenderDestinationID() const final;
WebSocketStream(const URL&, WebCore::SocketStreamHandleClient&, PAL::SessionID, const String& credentialPartition);
~WebSocketStream();
Modified: trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.h (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -93,8 +93,8 @@
void runOrDelayTaskForImport(WTF::Function<void()>&& task);
- IPC::Connection* messageSenderConnection() final { return m_connection.ptr(); }
- uint64_t messageSenderDestinationID() final { return m_identifier.toUInt64(); }
+ IPC::Connection* messageSenderConnection() const final { return m_connection.ptr(); }
+ uint64_t messageSenderDestinationID() const final { return m_identifier.toUInt64(); }
void setSWOriginTableSharedMemory(const SharedMemory::Handle&);
void setSWOriginTableIsImported();
Modified: trunk/Source/WebKit/WebProcess/WebConnectionToUIProcess.cpp (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/WebConnectionToUIProcess.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/WebConnectionToUIProcess.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -66,12 +66,12 @@
return m_process;
}
-IPC::Connection* WebConnectionToUIProcess::messageSenderConnection()
+IPC::Connection* WebConnectionToUIProcess::messageSenderConnection() const
{
return m_process->parentProcessConnection();
}
-uint64_t WebConnectionToUIProcess::messageSenderDestinationID()
+uint64_t WebConnectionToUIProcess::messageSenderDestinationID() const
{
return 0;
}
Modified: trunk/Source/WebKit/WebProcess/WebConnectionToUIProcess.h (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/WebConnectionToUIProcess.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/WebConnectionToUIProcess.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -23,8 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebConnectionToUIProcess_h
-#define WebConnectionToUIProcess_h
+#pragma once
#include "WebConnection.h"
@@ -47,12 +46,10 @@
bool hasValidConnection() const override;
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
WebProcess* m_process;
};
} // namespace WebKit
-
-#endif // WebConnectionToUIProcess_h
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-02-05 01:30:24 UTC (rev 240955)
@@ -790,12 +790,12 @@
#endif
}
-IPC::Connection* WebPage::messageSenderConnection()
+IPC::Connection* WebPage::messageSenderConnection() const
{
return WebProcess::singleton().parentProcessConnection();
}
-uint64_t WebPage::messageSenderDestinationID()
+uint64_t WebPage::messageSenderDestinationID() const
{
return pageID();
}
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (240954 => 240955)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2019-02-05 01:27:23 UTC (rev 240954)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2019-02-05 01:30:24 UTC (rev 240955)
@@ -1152,8 +1152,8 @@
void updateUserActivity();
// IPC::MessageSender
- IPC::Connection* messageSenderConnection() override;
- uint64_t messageSenderDestinationID() override;
+ IPC::Connection* messageSenderConnection() const override;
+ uint64_t messageSenderDestinationID() const override;
void platformInitialize();
void platformDetach();
