Title: [240966] trunk/Source/_javascript_Core
- Revision
- 240966
- Author
- ysuz...@apple.com
- Date
- 2019-02-04 22:51:29 -0800 (Mon, 04 Feb 2019)
Log Message
Unreviewed, add missing exception checks after r240637
https://bugs.webkit.org/show_bug.cgi?id=193546
* tools/JSDollarVM.cpp:
(JSC::functionShadowChickenFunctionsOnStack):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (240965 => 240966)
--- trunk/Source/_javascript_Core/ChangeLog 2019-02-05 06:32:08 UTC (rev 240965)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-02-05 06:51:29 UTC (rev 240966)
@@ -1,5 +1,13 @@
2019-02-04 Yusuke Suzuki <ysuz...@apple.com>
+ Unreviewed, add missing exception checks after r240637
+ https://bugs.webkit.org/show_bug.cgi?id=193546
+
+ * tools/JSDollarVM.cpp:
+ (JSC::functionShadowChickenFunctionsOnStack):
+
+2019-02-04 Yusuke Suzuki <ysuz...@apple.com>
+
[JSC] Shrink size of VM by lazily allocating IsoSubspaces for non-common types
https://bugs.webkit.org/show_bug.cgi?id=193993
Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (240965 => 240966)
--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2019-02-05 06:32:08 UTC (rev 240965)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp 2019-02-05 06:51:29 UTC (rev 240966)
@@ -1932,8 +1932,10 @@
{
VM& vm = exec->vm();
auto scope = DECLARE_THROW_SCOPE(vm);
- if (auto* shadowChicken = vm.shadowChicken())
+ if (auto* shadowChicken = vm.shadowChicken()) {
+ scope.release();
return JSValue::encode(shadowChicken->functionsOnStack(exec));
+ }
JSArray* result = constructEmptyArray(exec, 0);
RETURN_IF_EXCEPTION(scope, { });
@@ -1946,6 +1948,7 @@
scope.releaseAssertNoException(); // This function is only called from tests.
return StackVisitor::Continue;
});
+ RETURN_IF_EXCEPTION(scope, { });
return JSValue::encode(result);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
