Title: [241562] trunk/Tools
- Revision
- 241562
- Author
- aakash_j...@apple.com
- Date
- 2019-02-14 14:10:37 -0800 (Thu, 14 Feb 2019)
Log Message
[ews-app] status bubble should fetch builder name info from BuilderMapping table
https://bugs.webkit.org/show_bug.cgi?id=194599
Reviewed by Lucas Forschler.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (241561 => 241562)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-02-14 22:08:58 UTC (rev 241561)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2019-02-14 22:10:37 UTC (rev 241562)
@@ -26,6 +26,7 @@
from django.shortcuts import render
from django.views import View
from django.views.decorators.clickjacking import xframe_options_exempt
+from ews.models.buildermapping import BuilderMapping
from ews.models.patch import Patch
import ews.config as config
@@ -32,8 +33,12 @@
class StatusBubble(View):
def _build_bubble(self, build, patch):
- builder_display_name = build.builder_id # TODO: fetch display name from buildermapping table https://bugs.webkit.org/show_bug.cgi?id=194599
- builder_full_name = build.builder_id # TODO: fetch builder full name from buildermapping table https://bugs.webkit.org/show_bug.cgi?id=194599
+ try:
+ builder_display_name = build.builder.display_name
+ builder_full_name = build.builder.builder_name
+ except BuilderMapping.DoesNotExist:
+ builder_display_name = build.builder_id
+ builder_full_name = ''
bubble = {
"name": builder_display_name,
Modified: trunk/Tools/ChangeLog (241561 => 241562)
--- trunk/Tools/ChangeLog 2019-02-14 22:08:58 UTC (rev 241561)
+++ trunk/Tools/ChangeLog 2019-02-14 22:10:37 UTC (rev 241562)
@@ -1,5 +1,15 @@
2019-02-14 Aakash Jain <aakash_j...@apple.com>
+ [ews-app] status bubble should fetch builder name info from BuilderMapping table
+ https://bugs.webkit.org/show_bug.cgi?id=194599
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+ (StatusBubble._build_bubble):
+
+2019-02-14 Aakash Jain <aakash_j...@apple.com>
+
[ews-app] Set Foreign Key in Django build model
https://bugs.webkit.org/show_bug.cgi?id=194667
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
