Title: [242176] trunk/Source/WebCore
- Revision
- 242176
- Author
- za...@apple.com
- Date
- 2019-02-27 16:08:20 -0800 (Wed, 27 Feb 2019)
Log Message
[ContentChangeObserver] Move DOMTimer schedule handling from global to ContentChangeObserver class
https://bugs.webkit.org/show_bug.cgi?id=195090
<rdar://problem/48426771>
Reviewed by Tim Horton.
Also remove some unused functions from WKContentObservationInternal.
* page/ios/ContentChangeObserver.h:
* page/ios/ContentChangeObserver.mm:
(WebCore::ContentChangeObserver::startObservingDOMTimerScheduling):
(WebCore::ContentChangeObserver::stopObservingDOMTimerScheduling):
(WebCore::ContentChangeObserver::isObservingDOMTimerScheduling):
* platform/ios/wak/WKContentObservation.cpp:
(WKStartObservingDOMTimerScheduling): Deleted.
(WKStopObservingDOMTimerScheduling): Deleted.
(WKIsObservingDOMTimerScheduling): Deleted.
* platform/ios/wak/WKContentObservation.h:
* platform/ios/wak/WKContentObservationInternal.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (242175 => 242176)
--- trunk/Source/WebCore/ChangeLog 2019-02-28 00:02:03 UTC (rev 242175)
+++ trunk/Source/WebCore/ChangeLog 2019-02-28 00:08:20 UTC (rev 242176)
@@ -1,5 +1,27 @@
2019-02-27 Zalan Bujtas <za...@apple.com>
+ [ContentChangeObserver] Move DOMTimer schedule handling from global to ContentChangeObserver class
+ https://bugs.webkit.org/show_bug.cgi?id=195090
+ <rdar://problem/48426771>
+
+ Reviewed by Tim Horton.
+
+ Also remove some unused functions from WKContentObservationInternal.
+
+ * page/ios/ContentChangeObserver.h:
+ * page/ios/ContentChangeObserver.mm:
+ (WebCore::ContentChangeObserver::startObservingDOMTimerScheduling):
+ (WebCore::ContentChangeObserver::stopObservingDOMTimerScheduling):
+ (WebCore::ContentChangeObserver::isObservingDOMTimerScheduling):
+ * platform/ios/wak/WKContentObservation.cpp:
+ (WKStartObservingDOMTimerScheduling): Deleted.
+ (WKStopObservingDOMTimerScheduling): Deleted.
+ (WKIsObservingDOMTimerScheduling): Deleted.
+ * platform/ios/wak/WKContentObservation.h:
+ * platform/ios/wak/WKContentObservationInternal.h:
+
+2019-02-27 Zalan Bujtas <za...@apple.com>
+
[ContentChangeObserver] Move style recalc handling from global to ContentChangeObserver class
https://bugs.webkit.org/show_bug.cgi?id=195087
Modified: trunk/Source/WebCore/page/ios/ContentChangeObserver.h (242175 => 242176)
--- trunk/Source/WebCore/page/ios/ContentChangeObserver.h 2019-02-28 00:02:03 UTC (rev 242175)
+++ trunk/Source/WebCore/page/ios/ContentChangeObserver.h 2019-02-28 00:08:20 UTC (rev 242176)
@@ -97,6 +97,7 @@
HashSet<const DOMTimer*> m_DOMTimerList;
bool m_observingNextStyleRecalc { false };
bool m_observingStyleRecalcScheduling { false };
+ bool m_observingDOMTimerScheduling { false };
};
}
Modified: trunk/Source/WebCore/page/ios/ContentChangeObserver.mm (242175 => 242176)
--- trunk/Source/WebCore/page/ios/ContentChangeObserver.mm 2019-02-28 00:02:03 UTC (rev 242175)
+++ trunk/Source/WebCore/page/ios/ContentChangeObserver.mm 2019-02-28 00:08:20 UTC (rev 242176)
@@ -166,18 +166,18 @@
void ContentChangeObserver::startObservingDOMTimerScheduling()
{
- WKStartObservingDOMTimerScheduling();
+ m_observingDOMTimerScheduling = true;
clearObservedDOMTimers();
}
void ContentChangeObserver::stopObservingDOMTimerScheduling()
{
- WKStopObservingDOMTimerScheduling();
+ m_observingDOMTimerScheduling = false;
}
bool ContentChangeObserver::isObservingDOMTimerScheduling()
{
- return WKIsObservingDOMTimerScheduling();
+ return m_observingDOMTimerScheduling;
}
void ContentChangeObserver::startObservingStyleRecalcScheduling()
Modified: trunk/Source/WebCore/platform/ios/wak/WKContentObservation.cpp (242175 => 242176)
--- trunk/Source/WebCore/platform/ios/wak/WKContentObservation.cpp 2019-02-28 00:02:03 UTC (rev 242175)
+++ trunk/Source/WebCore/platform/ios/wak/WKContentObservation.cpp 2019-02-28 00:08:20 UTC (rev 242176)
@@ -36,7 +36,6 @@
WKContentChange _WKContentChange = WKContentNoChange;
bool _WKObservingContentChanges = false;
-bool _WKObservingDOMTimerScheduling = false;
bool WKObservingContentChanges(void)
{
@@ -54,21 +53,6 @@
_WKObservingContentChanges = false;
}
-void WKStartObservingDOMTimerScheduling(void)
-{
- _WKObservingDOMTimerScheduling = true;
-}
-
-void WKStopObservingDOMTimerScheduling(void)
-{
- _WKObservingDOMTimerScheduling = false;
-}
-
-bool WKIsObservingDOMTimerScheduling(void)
-{
- return _WKObservingDOMTimerScheduling;
-}
-
WKContentChange WKObservedContentChange(void)
{
return _WKContentChange;
Modified: trunk/Source/WebCore/platform/ios/wak/WKContentObservation.h (242175 => 242176)
--- trunk/Source/WebCore/platform/ios/wak/WKContentObservation.h 2019-02-28 00:02:03 UTC (rev 242175)
+++ trunk/Source/WebCore/platform/ios/wak/WKContentObservation.h 2019-02-28 00:08:20 UTC (rev 242176)
@@ -42,10 +42,6 @@
WEBCORE_EXPORT void WKStartObservingContentChanges(void);
WEBCORE_EXPORT void WKStopObservingContentChanges(void);
-WEBCORE_EXPORT void WKStartObservingDOMTimerScheduling(void);
-WEBCORE_EXPORT void WKStopObservingDOMTimerScheduling(void);
-WEBCORE_EXPORT bool WKIsObservingDOMTimerScheduling(void);
-
WEBCORE_EXPORT WKContentChange WKObservedContentChange(void);
#ifdef __cplusplus
Modified: trunk/Source/WebCore/platform/ios/wak/WKContentObservationInternal.h (242175 => 242176)
--- trunk/Source/WebCore/platform/ios/wak/WKContentObservationInternal.h 2019-02-28 00:02:03 UTC (rev 242175)
+++ trunk/Source/WebCore/platform/ios/wak/WKContentObservationInternal.h 2019-02-28 00:08:20 UTC (rev 242176)
@@ -36,9 +36,6 @@
bool WKObservingContentChanges(void);
void WKSetObservedContentChange(WKContentChange);
-bool WebThreadContainsObservedDOMTimer(void* timer);
-void WebThreadAddObservedDOMTimer(void* timer);
-void WebThreadRemoveObservedDOMTimer(void* timer);
#ifdef __cplusplus
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
