Title: [242179] trunk/Tools
- Revision
- 242179
- Author
- cdu...@apple.com
- Date
- 2019-02-27 16:43:38 -0800 (Wed, 27 Feb 2019)
Log Message
Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
https://bugs.webkit.org/show_bug.cgi?id=194545
Reviewed by Brady Eidson.
Make sure the test navigates forward and then back only once. Previously, navigating
back would trigger a navigation again in a timer.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (242178 => 242179)
--- trunk/Tools/ChangeLog 2019-02-28 00:19:21 UTC (rev 242178)
+++ trunk/Tools/ChangeLog 2019-02-28 00:43:38 UTC (rev 242179)
@@ -1,3 +1,15 @@
+2019-02-27 Chris Dumez <cdu...@apple.com>
+
+ Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
+ https://bugs.webkit.org/show_bug.cgi?id=194545
+
+ Reviewed by Brady Eidson.
+
+ Make sure the test navigates forward and then back only once. Previously, navigating
+ back would trigger a navigation again in a timer.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2019-02-13 Ryan Haddad <ryanhad...@apple.com>
High Sierra Debug JSC test queue should use faster hardware
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (242178 => 242179)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2019-02-28 00:19:21 UTC (rev 242178)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2019-02-28 00:43:38 UTC (rev 242179)
@@ -3748,6 +3748,12 @@
static const char* navigateToDataURLThenBackBytes = R"PSONRESOURCE(
<script>
_onpageshow_ = function(event) {
+ if (sessionStorage.getItem('navigated') == 'true') {
+ sessionStorage.clear();
+ return;
+ }
+ sessionStorage.setItem('navigated', 'true');
+
// Location changes need to happen outside the onload handler to generate history entries.
setTimeout(function() {
window.location.href = "" _onload_='history.back()'></body>";
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
