Title: [242847] trunk/Source
- Revision
- 242847
- Author
- hironori.fu...@sony.com
- Date
- 2019-03-13 00:48:12 -0700 (Wed, 13 Mar 2019)
Log Message
[Win][PlayStation] Remove WebCore::standardUserAgentForURL
https://bugs.webkit.org/show_bug.cgi?id=195662
Reviewed by Ryosuke Niwa.
Source/WebCore:
WebCore::standardUserAgentForURL is just a stub in Windows port.
No new tests because there is no behavior change.
* platform/win/UserAgentWin.cpp:
(WebCore::standardUserAgentForURL): Deleted.
* platform/playstation/UserAgentPlayStation.cpp:
(WebCore::standardUserAgentForURL): Deleted.
Source/WebKit:
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformUserAgent const): Return an empty string as well as mac/ios ports.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (242846 => 242847)
--- trunk/Source/WebCore/ChangeLog 2019-03-13 07:05:41 UTC (rev 242846)
+++ trunk/Source/WebCore/ChangeLog 2019-03-13 07:48:12 UTC (rev 242847)
@@ -1,3 +1,19 @@
+2019-03-13 Fujii Hironori <hironori.fu...@sony.com>
+
+ [Win][PlayStation] Remove WebCore::standardUserAgentForURL
+ https://bugs.webkit.org/show_bug.cgi?id=195662
+
+ Reviewed by Ryosuke Niwa.
+
+ WebCore::standardUserAgentForURL is just a stub in Windows port.
+
+ No new tests because there is no behavior change.
+
+ * platform/win/UserAgentWin.cpp:
+ (WebCore::standardUserAgentForURL): Deleted.
+ * platform/playstation/UserAgentPlayStation.cpp:
+ (WebCore::standardUserAgentForURL): Deleted.
+
2019-03-12 Ross Kirsling <ross.kirsl...@sony.com>
[Win] Fix a slew of simple clang-cl warnings.
Modified: trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp (242846 => 242847)
--- trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2019-03-13 07:05:41 UTC (rev 242846)
+++ trunk/Source/WebCore/platform/playstation/UserAgentPlayStation.cpp 2019-03-13 07:48:12 UTC (rev 242847)
@@ -33,10 +33,4 @@
return emptyString();
}
-String standardUserAgentForURL(const URL&)
-{
- // The null string means we don't need a specific UA for the given URL.
- return emptyString();
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/win/UserAgentWin.cpp (242846 => 242847)
--- trunk/Source/WebCore/platform/win/UserAgentWin.cpp 2019-03-13 07:05:41 UTC (rev 242846)
+++ trunk/Source/WebCore/platform/win/UserAgentWin.cpp 2019-03-13 07:48:12 UTC (rev 242847)
@@ -49,10 +49,4 @@
return uaString.toString();
}
-String standardUserAgentForURL(const URL& url)
-{
- // The null string means we don't need a specific UA for the given URL.
- return { };
-}
-
} // namespace WebCore
Modified: trunk/Source/WebKit/ChangeLog (242846 => 242847)
--- trunk/Source/WebKit/ChangeLog 2019-03-13 07:05:41 UTC (rev 242846)
+++ trunk/Source/WebKit/ChangeLog 2019-03-13 07:48:12 UTC (rev 242847)
@@ -1,3 +1,13 @@
+2019-03-13 Fujii Hironori <hironori.fu...@sony.com>
+
+ [Win][PlayStation] Remove WebCore::standardUserAgentForURL
+ https://bugs.webkit.org/show_bug.cgi?id=195662
+
+ Reviewed by Ryosuke Niwa.
+
+ * WebProcess/WebPage/win/WebPageWin.cpp:
+ (WebKit::WebPage::platformUserAgent const): Return an empty string as well as mac/ios ports.
+
2019-03-12 Ross Kirsling <ross.kirsl...@sony.com>
[Win] Fix a slew of simple clang-cl warnings.
Modified: trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp (242846 => 242847)
--- trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp 2019-03-13 07:05:41 UTC (rev 242846)
+++ trunk/Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp 2019-03-13 07:48:12 UTC (rev 242847)
@@ -113,12 +113,9 @@
return false;
}
-String WebPage::platformUserAgent(const URL& url) const
+String WebPage::platformUserAgent(const URL&) const
{
- if (url.isNull() || !m_page->settings().needsSiteSpecificQuirks())
- return String();
-
- return WebCore::standardUserAgentForURL(url);
+ return { };
}
static const unsigned CtrlKey = 1 << 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
