Title: [243597] trunk
Revision
243597
Author
sbar...@apple.com
Date
2019-03-27 18:47:29 -0700 (Wed, 27 Mar 2019)

Log Message

JetStream 2 should not report time values as scores
https://bugs.webkit.org/show_bug.cgi?id=196334

Reviewed by Yusuke Suzuki.

PerformanceTests:

* JetStream2/JetStreamDriver.js:
(toTimeValue):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):

Websites/browserbench.org:

* JetStream2.0/JetStreamDriver.js:
(toTimeValue):
(Driver.prototype.async.reportScoreToRunBenchmarkRunner):

Modified Paths

Diff

Modified: trunk/PerformanceTests/ChangeLog (243596 => 243597)


--- trunk/PerformanceTests/ChangeLog	2019-03-28 01:06:01 UTC (rev 243596)
+++ trunk/PerformanceTests/ChangeLog	2019-03-28 01:47:29 UTC (rev 243597)
@@ -1,3 +1,14 @@
+2019-03-27  Saam Barati  <sbar...@apple.com>
+
+        JetStream 2 should not report time values as scores
+        https://bugs.webkit.org/show_bug.cgi?id=196334
+
+        Reviewed by Yusuke Suzuki.
+
+        * JetStream2/JetStreamDriver.js:
+        (toTimeValue):
+        (Driver.prototype.async.reportScoreToRunBenchmarkRunner):
+
 2019-03-27  Saam barati  <sbar...@apple.com>
 
         Unreviewed. Fix individual benchmark description urls to go to in-depth.html instead of about.html

Modified: trunk/PerformanceTests/JetStream2/JetStreamDriver.js (243596 => 243597)


--- trunk/PerformanceTests/JetStream2/JetStreamDriver.js	2019-03-28 01:06:01 UTC (rev 243596)
+++ trunk/PerformanceTests/JetStream2/JetStreamDriver.js	2019-03-28 01:47:29 UTC (rev 243597)
@@ -82,6 +82,10 @@
     return 5000 / timeValue;
 }
 
+function toTimeValue(score) {
+    return 5000 / score;
+}
+
 function updateUI() {
     return new Promise((resolve) => {
         if (isInBrowser)
@@ -319,7 +323,7 @@
             const subResults = {}
             const subTimes = benchmark.subTimes();
             for (const name in subTimes) {
-                subResults[name] = {"metrics": {"Time": {"current": [subTimes[name]]}}};
+                subResults[name] = {"metrics": {"Time": {"current": [toTimeValue(subTimes[name])]}}};
             }
             results[benchmark.name] = {
                 "metrics" : {

Modified: trunk/Websites/browserbench.org/ChangeLog (243596 => 243597)


--- trunk/Websites/browserbench.org/ChangeLog	2019-03-28 01:06:01 UTC (rev 243596)
+++ trunk/Websites/browserbench.org/ChangeLog	2019-03-28 01:47:29 UTC (rev 243597)
@@ -1,3 +1,14 @@
+2019-03-27  Saam Barati  <sbar...@apple.com>
+
+        JetStream 2 should not report time values as scores
+        https://bugs.webkit.org/show_bug.cgi?id=196334
+
+        Reviewed by Yusuke Suzuki.
+
+        * JetStream2.0/JetStreamDriver.js:
+        (toTimeValue):
+        (Driver.prototype.async.reportScoreToRunBenchmarkRunner):
+
 2019-03-27  Saam barati  <sbar...@apple.com>
 
         Unreviewed. Fix individual benchmark description urls to go to in-depth.html instead of about.html

Modified: trunk/Websites/browserbench.org/JetStream2.0/JetStreamDriver.js (243596 => 243597)


--- trunk/Websites/browserbench.org/JetStream2.0/JetStreamDriver.js	2019-03-28 01:06:01 UTC (rev 243596)
+++ trunk/Websites/browserbench.org/JetStream2.0/JetStreamDriver.js	2019-03-28 01:47:29 UTC (rev 243597)
@@ -82,6 +82,10 @@
     return 5000 / timeValue;
 }
 
+function toTimeValue(score) {
+    return 5000 / score;
+}
+
 function updateUI() {
     return new Promise((resolve) => {
         if (isInBrowser)
@@ -319,7 +323,7 @@
             const subResults = {}
             const subTimes = benchmark.subTimes();
             for (const name in subTimes) {
-                subResults[name] = {"metrics": {"Time": {"current": [subTimes[name]]}}};
+                subResults[name] = {"metrics": {"Time": {"current": [toTimeValue(subTimes[name])]}}};
             }
             results[benchmark.name] = {
                 "metrics" : {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to