Title: [244228] trunk
Revision
244228
Author
simon.fra...@apple.com
Date
2019-04-12 11:52:01 -0700 (Fri, 12 Apr 2019)

Log Message

[iOS WK2] Make -webkit-overflow-scrolling be a no-op
https://bugs.webkit.org/show_bug.cgi?id=196803
rdar://problem/49078202

Reviewed by Antti Koivisto.

Source/WebKit:

Flip LegacyOverflowScrollingTouchEnabled to false.

* Shared/WebPreferences.yaml:

LayoutTests:

Rebase some tests, if I thought that non-stacking context overflow was interesting.
For others, make overflow be stacking context by adding z-index.
Add <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> to those that
need it.

* compositing/overflow/scrolling-content-clip-to-viewport.html:
* compositing/rtl/rtl-scrolling-with-transformed-descendants.html:
* fast/scrolling/ios/change-scrollability-on-content-resize-nested.html:
* fast/scrolling/ios/overflow-scroll-inherited-expected.txt:
* fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html:
* fast/scrolling/ios/overflow-scrolling-ancestor-clip.html:
* fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt:
* fast/scrolling/ios/reconcile-layer-position-recursive.html:
* fast/scrolling/ios/scrolling-content-clip-to-viewport.html:
* fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html:
* fast/scrolling/ios/touch-scroll-pointer-events-none.html:
* fast/scrolling/ios/touch-scroll-visibility-hidden.html:
* platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
* platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt:
* scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html:
* scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html:
* scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html:
* scrollingcoordinator/scrolling-tree/coordinated-frame.html:
* scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (244227 => 244228)


--- trunk/LayoutTests/ChangeLog	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/ChangeLog	2019-04-12 18:52:01 UTC (rev 244228)
@@ -4,6 +4,39 @@
 
         * platform/win/TestExpectations:
 
+2019-04-12  Simon Fraser  <simon.fra...@apple.com>
+
+        [iOS WK2] Make -webkit-overflow-scrolling be a no-op
+        https://bugs.webkit.org/show_bug.cgi?id=196803
+        rdar://problem/49078202
+
+        Reviewed by Antti Koivisto.
+
+        Rebase some tests, if I thought that non-stacking context overflow was interesting.
+        For others, make overflow be stacking context by adding z-index.
+        Add <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] --> to those that
+        need it.
+
+        * compositing/overflow/scrolling-content-clip-to-viewport.html:
+        * compositing/rtl/rtl-scrolling-with-transformed-descendants.html:
+        * fast/scrolling/ios/change-scrollability-on-content-resize-nested.html:
+        * fast/scrolling/ios/overflow-scroll-inherited-expected.txt:
+        * fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html:
+        * fast/scrolling/ios/overflow-scrolling-ancestor-clip.html:
+        * fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt:
+        * fast/scrolling/ios/reconcile-layer-position-recursive.html:
+        * fast/scrolling/ios/scrolling-content-clip-to-viewport.html:
+        * fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html:
+        * fast/scrolling/ios/touch-scroll-pointer-events-none.html:
+        * fast/scrolling/ios/touch-scroll-visibility-hidden.html:
+        * platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
+        * platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt:
+        * scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html:
+        * scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html:
+        * scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html:
+        * scrollingcoordinator/scrolling-tree/coordinated-frame.html:
+        * scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:
+
 2019-04-12  Wenson Hsieh  <wenson_hs...@apple.com>
 
         [iOS] Software keyboard is shown too frequently on some websites

Modified: trunk/LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html (244227 => 244228)


--- trunk/LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -7,7 +7,6 @@
   <style>
     body {
       margin: 0;
-      -webkit-overflow-scrolling: touch;
     }
 
     .scroller {

Modified: trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (244227 => 244228)


--- trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -6,7 +6,7 @@
     (GraphicsLayer
       (bounds 800.00 600.00)
       (contentsOpaque 1)
-      (children 4
+      (children 1
         (GraphicsLayer
           (position 8.00 8.00)
           (bounds 404.00 223.00)
@@ -24,48 +24,19 @@
                   (anchor 0.00 0.00)
                   (bounds 766.00 204.00)
                   (drawsContent 1)
+                  (children 1
+                    (GraphicsLayer
+                      (position 462.00 0.00)
+                      (anchor 0.00 0.00)
+                      (bounds 150.00 200.00)
+                      (contentsOpaque 1)
+                    )
+                  )
                 )
               )
             )
           )
         )
-        (GraphicsLayer
-          (offsetFromRenderer width=-250 height=0)
-          (position 10.00 10.00)
-          (bounds 400.00 204.00)
-          (children 1
-            (GraphicsLayer
-              (position 250.00 0.00)
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
-            )
-          )
-        )
-        (GraphicsLayer
-          (offsetFromRenderer width=-96 height=0)
-          (position 10.00 10.00)
-          (bounds 400.00 204.00)
-          (children 1
-            (GraphicsLayer
-              (position 96.00 0.00)
-              (anchor 0.00 0.00)
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
-            )
-          )
-        )
-        (GraphicsLayer
-          (offsetFromRenderer width=58 height=0)
-          (position 10.00 10.00)
-          (bounds 400.00 204.00)
-          (children 1
-            (GraphicsLayer
-              (position -58.00 0.00)
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
-            )
-          )
-        )
       )
     )
   )

Modified: trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html (244227 => 244228)


--- trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -3,10 +3,11 @@
   <head>
     <style type="text/css">
         #scroller {
+            position: relative;
+            z-index: 0;
             overflow-x: auto;
             width: 400px;
             white-space: nowrap;
-            -webkit-overflow-scrolling: touch;
             border: 2px solid black;
         }
 

Modified: trunk/LayoutTests/fast/scrolling/ios/change-scrollability-on-content-resize-nested.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/change-scrollability-on-content-resize-nested.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/change-scrollability-on-content-resize-nested.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -14,8 +14,8 @@
             height: 100%;
             overflow-x: hidden;
             overflow-y: scroll;
-            -webkit-overflow-scrolling: touch;
             position: relative;
+            z-index: 0;
         }
         #content {
             background-color: yellow;

Modified: trunk/LayoutTests/fast/scrolling/ios/overflow-scroll-inherited-expected.txt (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/overflow-scroll-inherited-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/overflow-scroll-inherited-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -1,5 +1,5 @@
-test1 -webkit-overflow-scrolling: touch
+test1 -webkit-overflow-scrolling: auto
 test2 -webkit-overflow-scrolling: auto
-test3 -webkit-overflow-scrolling: touch
-test4 -webkit-overflow-scrolling: touch
+test3 -webkit-overflow-scrolling: auto
+test4 -webkit-overflow-scrolling: auto
 

Modified: trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -19,8 +19,9 @@
   </script>
   <style>
     #scroller {
+      position: relative;
+      z-index: 0;
       overflow: scroll;
-      -webkit-overflow-scrolling: touch;
       width: 300px;
       height: 400px;
       border: 11px solid black;

Modified: trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -19,8 +19,9 @@
   </script>
   <style>
     #scroller {
+      position: relative;
+      z-index: 0;
       overflow: scroll;
-      -webkit-overflow-scrolling: touch;
       width: 300px;
       height: 400px;
       border: 1px solid black;

Modified: trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -17,7 +17,7 @@
       (tile size 800 x 512)
       (top left tile 0, 1 tiles grid 1 x 3)
       (in window 1)
-      (children 1
+      (children 3
         (GraphicsLayer
           (position 8.00 1008.00)
           (bounds 300.00 300.00)
@@ -70,56 +70,6 @@
                               (coverage rect 0.00, 0.00 200.00 x 245.00)
                               (intersects coverage rect 1)
                               (contentsScale 2.00)
-                              (children 2
-                                (GraphicsLayer
-                                  (position 7.00 28.00)
-                                  (approximate position 7.00 28.00)
-                                  (bounds 110.00 110.00)
-                                  (contentsOpaque 1)
-                                  (drawsContent 1)
-                                  (visible rect 0.00, 0.00 110.00 x 110.00)
-                                  (coverage rect -7.00, -28.00 200.00 x 245.00)
-                                  (intersects coverage rect 1)
-                                  (contentsScale 2.00)
-                                  (children 1
-                                    (GraphicsLayer
-                                      (position 55.00 55.00)
-                                      (approximate position 55.00 55.00)
-                                      (bounds 110.00 110.00)
-                                      (contentsOpaque 1)
-                                      (drawsContent 1)
-                                      (visible rect 0.00, 0.00 110.00 x 110.00)
-                                      (coverage rect -62.00, -83.00 200.00 x 245.00)
-                                      (intersects coverage rect 1)
-                                      (contentsScale 2.00)
-                                    )
-                                  )
-                                )
-                                (GraphicsLayer
-                                  (position 105.00 395.00)
-                                  (approximate position 105.00 395.00)
-                                  (bounds 110.00 110.00)
-                                  (contentsOpaque 1)
-                                  (drawsContent 1)
-                                  (visible rect 0.00, 0.00 0.00 x 0.00)
-                                  (coverage rect -105.00, -395.00 200.00 x 245.00)
-                                  (intersects coverage rect 1)
-                                  (contentsScale 2.00)
-                                  (children 1
-                                    (GraphicsLayer
-                                      (position 55.00 55.00)
-                                      (approximate position 55.00 55.00)
-                                      (bounds 110.00 110.00)
-                                      (contentsOpaque 1)
-                                      (drawsContent 1)
-                                      (visible rect 0.00, 0.00 0.00 x 0.00)
-                                      (coverage rect -160.00, -450.00 200.00 x 245.00)
-                                      (intersects coverage rect 1)
-                                      (contentsScale 2.00)
-                                    )
-                                  )
-                                )
-                              )
                             )
                           )
                         )
@@ -131,6 +81,65 @@
             )
           )
         )
+        (GraphicsLayer
+          (position 70.00 1091.00)
+          (approximate position 70.00 1091.00)
+          (bounds 110.00 110.00)
+          (contentsOpaque 1)
+          (drawsContent 1)
+          (visible rect 0.00, 0.00 110.00 x 110.00)
+          (coverage rect -70.00, -326.00 1056.00 x 856.00)
+          (intersects coverage rect 1)
+          (contentsScale 2.00)
+          (children 1
+            (GraphicsLayer
+              (position 55.00 55.00)
+              (approximate position 55.00 55.00)
+              (bounds 110.00 110.00)
+              (contentsOpaque 1)
+              (drawsContent 1)
+              (visible rect 0.00, 0.00 110.00 x 110.00)
+              (coverage rect -125.00, -381.00 1056.00 x 856.00)
+              (intersects coverage rect 1)
+              (contentsScale 2.00)
+            )
+          )
+        )
+        (GraphicsLayer
+          (offsetFromRenderer width=-105 height=-105)
+          (position 63.00 1063.00)
+          (bounds 200.00 245.00)
+          (visible rect 0.00, 0.00 200.00 x 245.00)
+          (coverage rect 0.00, 0.00 200.00 x 245.00)
+          (intersects coverage rect 1)
+          (contentsScale 2.00)
+          (children 1
+            (GraphicsLayer
+              (position 105.00 395.00)
+              (approximate position 105.00 395.00)
+              (bounds 110.00 110.00)
+              (contentsOpaque 1)
+              (drawsContent 1)
+              (visible rect 0.00, 0.00 0.00 x 0.00)
+              (coverage rect -105.00, -395.00 200.00 x 245.00)
+              (intersects coverage rect 1)
+              (contentsScale 2.00)
+              (children 1
+                (GraphicsLayer
+                  (position 55.00 55.00)
+                  (approximate position 55.00 55.00)
+                  (bounds 110.00 110.00)
+                  (contentsOpaque 1)
+                  (drawsContent 1)
+                  (visible rect 0.00, 0.00 0.00 x 0.00)
+                  (coverage rect -160.00, -450.00 200.00 x 245.00)
+                  (intersects coverage rect 1)
+                  (contentsScale 2.00)
+                )
+              )
+            )
+          )
+        )
       )
     )
   )

Modified: trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -11,7 +11,6 @@
       .scrollable {
          background: linear-gradient(135deg, cyan, green);
          overflow: auto;
-         -webkit-overflow-scrolling: touch;
       }
       .fixed {
          position: fixed;

Modified: trunk/LayoutTests/fast/scrolling/ios/scrolling-content-clip-to-viewport.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/scrolling-content-clip-to-viewport.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/scrolling-content-clip-to-viewport.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -6,7 +6,6 @@
   <style>
     body {
       margin: 0;
-      -webkit-overflow-scrolling: touch;
     }
 
     .scroller {

Modified: trunk/LayoutTests/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -19,8 +19,9 @@
   </script>
   <style>
     #scroller {
+      position: relative;
+      z-index: 0;
       overflow: scroll;
-      -webkit-overflow-scrolling: touch;
       width: 300px;
       height: 400px;
     }

Modified: trunk/LayoutTests/fast/scrolling/ios/touch-scroll-pointer-events-none.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/touch-scroll-pointer-events-none.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/touch-scroll-pointer-events-none.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -25,12 +25,12 @@
         
         .container {
             position: absolute;
+            z-index: 0;
             top: 50px;
             left: 50px;
             height: 300px;
             width: 300px;
             overflow: scroll;
-            -webkit-overflow-scrolling: touch;
             border: 1px solid black;
             pointer-events: none;
             box-shadow: 0 0 10px black;

Modified: trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden.html (244227 => 244228)


--- trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -1,5 +1,4 @@
-<!DOCTYPE html>
-
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
 <html>
 <head>
     <meta name="viewport" content="initial-scale=1.0">
@@ -26,12 +25,12 @@
         
         .container {
             position: absolute;
+            z-index: 0;
             top: 50px;
             left: 50px;
             height: 300px;
             width: 300px;
             overflow: scroll;
-            -webkit-overflow-scrolling: touch;
             border: 1px solid black;
             visibility: hidden;
             box-shadow: 0 0 10px black;

Modified: trunk/LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt (244227 => 244228)


--- trunk/LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -5,7 +5,7 @@
     (GraphicsLayer
       (bounds 800.00 600.00)
       (contentsOpaque 1)
-      (children 1
+      (children 2
         (GraphicsLayer
           (bounds 320.00 340.00)
           (children 1
@@ -15,12 +15,23 @@
                 (GraphicsLayer
                   (anchor 0.00 0.00)
                   (bounds 320.00 1224.00)
-                  (drawsContent 1)
                 )
               )
             )
           )
         )
+        (GraphicsLayer
+          (offsetFromRenderer width=-10 height=-10)
+          (bounds 320.00 340.00)
+          (children 1
+            (GraphicsLayer
+              (position 10.00 10.00)
+              (bounds 284.00 1204.00)
+              (contentsOpaque 1)
+              (drawsContent 1)
+            )
+          )
+        )
       )
     )
   )

Modified: trunk/LayoutTests/platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt (244227 => 244228)


--- trunk/LayoutTests/platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -5,7 +5,7 @@
     (GraphicsLayer
       (bounds 320.00 548.00)
       (contentsOpaque 1)
-      (children 1
+      (children 2
         (GraphicsLayer
           (bounds 320.00 340.00)
           (children 1
@@ -15,12 +15,23 @@
                 (GraphicsLayer
                   (anchor 0.00 0.00)
                   (bounds 320.00 1224.00)
-                  (drawsContent 1)
                 )
               )
             )
           )
         )
+        (GraphicsLayer
+          (offsetFromRenderer width=-10 height=-10)
+          (bounds 320.00 340.00)
+          (children 1
+            (GraphicsLayer
+              (position 10.00 10.00)
+              (bounds 284.00 1204.00)
+              (contentsOpaque 1)
+              (drawsContent 1)
+            )
+          )
+        )
       )
     )
   )

Modified: trunk/LayoutTests/platform/mac-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt (244227 => 244228)


--- trunk/LayoutTests/platform/mac-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/platform/mac-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -8,15 +8,21 @@
       (contentsOpaque 1)
       (children 1
         (GraphicsLayer
-          (offsetFromRenderer width=-96 height=0)
-          (position 10.00 10.00)
-          (bounds 400.00 204.00)
+          (position 8.00 8.00)
+          (bounds 404.00 223.00)
           (children 1
             (GraphicsLayer
-              (position 96.00 0.00)
-              (anchor 0.00 0.00)
-              (bounds 150.00 200.00)
-              (contentsOpaque 1)
+              (offsetFromRenderer width=2 height=2)
+              (position 2.00 2.00)
+              (bounds 400.00 204.00)
+              (children 1
+                (GraphicsLayer
+                  (position 96.00 0.00)
+                  (anchor 0.00 0.00)
+                  (bounds 150.00 200.00)
+                  (contentsOpaque 1)
+                )
+              )
             )
           )
         )

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -12,8 +12,6 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
-  (synchronous event dispatch region for event wheel
-    at (45,47) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Frame hosting node
@@ -33,7 +31,30 @@
           (min layout viewport origin (0,0))
           (max layout viewport origin (0,120))
           (behavior for fixed 0)
-          (children 1
+          (children 2
+            (Overflow scrolling node
+              (scrollable area size 385 285)
+              (contents size 385 1760)
+              (parent relative scrollable rect at (10,10) size 385x285)
+              (scrollable area parameters 
+                (horizontal scroll elasticity 0)
+                (vertical scroll elasticity 0)
+                (horizontal scrollbar mode 0)
+                (vertical scrollbar mode 0)
+                (has enabled vertical scrollbar 1))
+              (children 1
+                (Sticky node
+                  (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
+                  (top offset 10.00)
+                  (bottom offset 10.00)
+                  (containing block rect at (2,2) size 385x1760)
+                  (sticky box rect at (0,830) size 100x100)
+                  (constraining rect at (0,0) size 385x285)
+                  (sticky offset at last layout width=0 height=-655)
+                  (layer position at last layout (0,175))
+                )
+              )
+            )
             (Sticky node
               (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
               (top offset 10.00)

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -12,8 +12,6 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
-  (synchronous event dispatch region for event wheel
-    at (45,47) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Fixed node
@@ -37,7 +35,30 @@
               (min layout viewport origin (0,0))
               (max layout viewport origin (0,120))
               (behavior for fixed 0)
-              (children 1
+              (children 2
+                (Overflow scrolling node
+                  (scrollable area size 385 285)
+                  (contents size 385 1760)
+                  (parent relative scrollable rect at (10,10) size 385x285)
+                  (scrollable area parameters 
+                    (horizontal scroll elasticity 0)
+                    (vertical scroll elasticity 0)
+                    (horizontal scrollbar mode 0)
+                    (vertical scrollbar mode 0)
+                    (has enabled vertical scrollbar 1))
+                  (children 1
+                    (Sticky node
+                      (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
+                      (top offset 10.00)
+                      (bottom offset 10.00)
+                      (containing block rect at (2,2) size 385x1760)
+                      (sticky box rect at (0,830) size 100x100)
+                      (constraining rect at (0,0) size 385x285)
+                      (sticky offset at last layout width=0 height=-655)
+                      (layer position at last layout (0,175))
+                    )
+                  )
+                )
                 (Sticky node
                   (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
                   (top offset 10.00)

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
 <html>
 <head>
     <style>

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -12,8 +12,6 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
-  (synchronous event dispatch region for event wheel
-    at (45,37) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Fixed node
@@ -38,7 +36,30 @@
               (min layout viewport origin (0,0))
               (max layout viewport origin (0,120))
               (behavior for fixed 0)
-              (children 1
+              (children 2
+                (Overflow scrolling node
+                  (scrollable area size 385 285)
+                  (contents size 385 1760)
+                  (parent relative scrollable rect at (10,10) size 385x285)
+                  (scrollable area parameters 
+                    (horizontal scroll elasticity 0)
+                    (vertical scroll elasticity 0)
+                    (horizontal scrollbar mode 0)
+                    (vertical scrollbar mode 0)
+                    (has enabled vertical scrollbar 1))
+                  (children 1
+                    (Sticky node
+                      (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
+                      (top offset 10.00)
+                      (bottom offset 10.00)
+                      (containing block rect at (2,2) size 385x1760)
+                      (sticky box rect at (0,830) size 100x100)
+                      (constraining rect at (0,0) size 385x285)
+                      (sticky offset at last layout width=0 height=-655)
+                      (layer position at last layout (0,175))
+                    )
+                  )
+                )
                 (Sticky node
                   (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
                   (top offset 10.00)

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
 <html>
 <head>
     <style>

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt	2019-04-12 18:52:01 UTC (rev 244228)
@@ -12,8 +12,6 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
-  (synchronous event dispatch region for event wheel
-    at (45,47) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Frame hosting node
@@ -32,7 +30,30 @@
           (min layout viewport origin (0,0))
           (max layout viewport origin (0,120))
           (behavior for fixed 0)
-          (children 1
+          (children 2
+            (Overflow scrolling node
+              (scrollable area size 385 285)
+              (contents size 385 1760)
+              (parent relative scrollable rect at (10,10) size 385x285)
+              (scrollable area parameters 
+                (horizontal scroll elasticity 0)
+                (vertical scroll elasticity 0)
+                (horizontal scrollbar mode 0)
+                (vertical scrollbar mode 0)
+                (has enabled vertical scrollbar 1))
+              (children 1
+                (Sticky node
+                  (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
+                  (top offset 10.00)
+                  (bottom offset 10.00)
+                  (containing block rect at (2,2) size 385x1760)
+                  (sticky box rect at (0,830) size 100x100)
+                  (constraining rect at (0,0) size 385x285)
+                  (sticky offset at last layout width=0 height=-655)
+                  (layer position at last layout (0,175))
+                )
+              )
+            )
             (Sticky node
               (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
               (top offset 10.00)

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
 <html>
 <head>
     <style>

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame.html (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -1,4 +1,4 @@
-<!DOCTYPE html>
+<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
 <html>
 <head>
     <style>

Modified: trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html (244227 => 244228)


--- trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html	2019-04-12 18:52:01 UTC (rev 244228)
@@ -9,10 +9,11 @@
         }
         
         .scrolling {
+            position: relative;
+            z-index: 0;
             height: 300px;
             width: 400px;
             overflow: scroll;
-            -webkit-overflow-scrolling: touch;
             border: 2px solid black;
         }
         

Modified: trunk/Source/WebKit/ChangeLog (244227 => 244228)


--- trunk/Source/WebKit/ChangeLog	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/Source/WebKit/ChangeLog	2019-04-12 18:52:01 UTC (rev 244228)
@@ -59,6 +59,18 @@
         * UIProcess/API/APIWebsitePolicies.cpp:
         (API::WebsitePolicies::copy const):
 
+2019-04-12  Simon Fraser  <simon.fra...@apple.com>
+
+        [iOS WK2] Make -webkit-overflow-scrolling be a no-op
+        https://bugs.webkit.org/show_bug.cgi?id=196803
+        rdar://problem/49078202
+
+        Reviewed by Antti Koivisto.
+
+        Flip LegacyOverflowScrollingTouchEnabled to false.
+
+        * Shared/WebPreferences.yaml:
+
 2019-04-12  Wenson Hsieh  <wenson_hs...@apple.com>
 
         [iOS] Software keyboard is shown too frequently on some websites

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (244227 => 244228)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-04-12 18:34:43 UTC (rev 244227)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2019-04-12 18:52:01 UTC (rev 244228)
@@ -1453,7 +1453,7 @@
 
 LegacyOverflowScrollingTouchEnabled:
   type: bool
-  defaultValue: true
+  defaultValue: false
   humanReadableName: "Legacy -webkit-overflow-scrolling property"
   humanReadableDescription: "Support the legacy -webkit-overflow-scrolling CSS property"
   condition: ENABLE(OVERFLOW_SCROLLING_TOUCH)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to