Title: [244529] trunk
- Revision
- 244529
- Author
- commit-qu...@webkit.org
- Date
- 2019-04-22 17:15:03 -0700 (Mon, 22 Apr 2019)
Log Message
Deprecate WKContextCreateWithInjectedBundlePath
https://bugs.webkit.org/show_bug.cgi?id=197169
Patch by Alex Christensen <achristen...@webkit.org> on 2019-04-22
Reviewed by Youenn Fablet.
Source/WebKit:
* UIProcess/API/C/WKContext.h:
Tools:
* TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::createContextWithInjectedBundle):
Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244528 => 244529)
--- trunk/Source/WebKit/ChangeLog 2019-04-23 00:07:41 UTC (rev 244528)
+++ trunk/Source/WebKit/ChangeLog 2019-04-23 00:15:03 UTC (rev 244529)
@@ -1,5 +1,14 @@
2019-04-22 Alex Christensen <achristen...@webkit.org>
+ Deprecate WKContextCreateWithInjectedBundlePath
+ https://bugs.webkit.org/show_bug.cgi?id=197169
+
+ Reviewed by Youenn Fablet.
+
+ * UIProcess/API/C/WKContext.h:
+
+2019-04-22 Alex Christensen <achristen...@webkit.org>
+
REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
https://bugs.webkit.org/show_bug.cgi?id=197093
<rdar://problem/49708268>
Modified: trunk/Source/WebKit/UIProcess/API/C/WKContext.h (244528 => 244529)
--- trunk/Source/WebKit/UIProcess/API/C/WKContext.h 2019-04-23 00:07:41 UTC (rev 244528)
+++ trunk/Source/WebKit/UIProcess/API/C/WKContext.h 2019-04-23 00:15:03 UTC (rev 244529)
@@ -107,7 +107,7 @@
WK_EXPORT WKTypeID WKContextGetTypeID();
WK_EXPORT WKContextRef WKContextCreate() WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextCreateWithConfiguration);
-WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path);
+WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKContextCreateWithConfiguration);
WK_EXPORT WKContextRef WKContextCreateWithConfiguration(WKContextConfigurationRef configuration);
WK_EXPORT void WKContextSetClient(WKContextRef context, const WKContextClientBase* client);
Modified: trunk/Tools/ChangeLog (244528 => 244529)
--- trunk/Tools/ChangeLog 2019-04-23 00:07:41 UTC (rev 244528)
+++ trunk/Tools/ChangeLog 2019-04-23 00:15:03 UTC (rev 244529)
@@ -1,5 +1,16 @@
2019-04-22 Alex Christensen <achristen...@webkit.org>
+ Deprecate WKContextCreateWithInjectedBundlePath
+ https://bugs.webkit.org/show_bug.cgi?id=197169
+
+ Reviewed by Youenn Fablet.
+
+ * TestWebKitAPI/PlatformUtilities.cpp:
+ (TestWebKitAPI::Util::createContextWithInjectedBundle):
+ Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
+
+2019-04-22 Alex Christensen <achristen...@webkit.org>
+
REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
https://bugs.webkit.org/show_bug.cgi?id=197093
<rdar://problem/49708268>
Modified: trunk/Tools/TestWebKitAPI/PlatformUtilities.cpp (244528 => 244529)
--- trunk/Tools/TestWebKitAPI/PlatformUtilities.cpp 2019-04-23 00:07:41 UTC (rev 244528)
+++ trunk/Tools/TestWebKitAPI/PlatformUtilities.cpp 2019-04-23 00:15:03 UTC (rev 244529)
@@ -26,6 +26,7 @@
#include "config.h"
#include "PlatformUtilities.h"
+#include <WebKit/WKContextConfigurationRef.h>
#include <wtf/StdLibExtras.h>
namespace TestWebKitAPI {
@@ -36,9 +37,9 @@
WKContextRef createContextWithInjectedBundle()
{
WKRetainPtr<WKStringRef> injectedBundlePath = adoptWK(createInjectedBundlePath());
- WKContextRef context = WKContextCreateWithInjectedBundlePath(injectedBundlePath.get());
-
- return context;
+ auto configuration = adoptWK(WKContextConfigurationCreate());
+ WKContextConfigurationSetInjectedBundlePath(configuration.get(), injectedBundlePath.get());
+ return WKContextCreateWithConfiguration(configuration.get());
}
WKDictionaryRef createInitializationDictionaryForInjectedBundleTest(const std::string& testName, WKTypeRef userData)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
