Title: [244993] trunk/Source/WebKit
- Revision
- 244993
- Author
- wenson_hs...@apple.com
- Date
- 2019-05-06 17:08:10 -0700 (Mon, 06 May 2019)
Log Message
Occasional crashes in layout tests when firing the shrink-to-fit-content timer
https://bugs.webkit.org/show_bug.cgi?id=197629
<rdar://problem/50514382>
Reviewed by Tim Horton.
Fixes several crashing layout tests by stopping the shrink-to-fit-content timer when the page closes.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (244992 => 244993)
--- trunk/Source/WebKit/ChangeLog 2019-05-07 00:04:38 UTC (rev 244992)
+++ trunk/Source/WebKit/ChangeLog 2019-05-07 00:08:10 UTC (rev 244993)
@@ -1,3 +1,16 @@
+2019-05-06 Wenson Hsieh <wenson_hs...@apple.com>
+
+ Occasional crashes in layout tests when firing the shrink-to-fit-content timer
+ https://bugs.webkit.org/show_bug.cgi?id=197629
+ <rdar://problem/50514382>
+
+ Reviewed by Tim Horton.
+
+ Fixes several crashing layout tests by stopping the shrink-to-fit-content timer when the page closes.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::close):
+
2019-05-04 Per Arne Vollan <pvol...@apple.com>
-[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (244992 => 244993)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-05-07 00:04:38 UTC (rev 244992)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2019-05-07 00:08:10 UTC (rev 244993)
@@ -1353,6 +1353,10 @@
m_determinePrimarySnapshottedPlugInTimer.stop();
#endif
+#if ENABLE(VIEWPORT_RESIZING)
+ m_shrinkToFitContentTimer.stop();
+#endif
+
#if ENABLE(CONTEXT_MENUS)
m_contextMenuClient = std::make_unique<API::InjectedBundle::PageContextMenuClient>();
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes