Title: [246403] trunk/LayoutTests
Revision
246403
Author
you...@apple.com
Date
2019-06-13 08:07:18 -0700 (Thu, 13 Jun 2019)

Log Message

Update service worker test and expectation after revision 246363
https://bugs.webkit.org/show_bug.cgi?id=198808

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:
Make sure the fetch load finishes so that removing the frame does not cancel the fetch.

LayoutTests:

* TestExpectations:
Skip timing out test in Debug

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (246402 => 246403)


--- trunk/LayoutTests/ChangeLog	2019-06-13 14:50:59 UTC (rev 246402)
+++ trunk/LayoutTests/ChangeLog	2019-06-13 15:07:18 UTC (rev 246403)
@@ -1,3 +1,13 @@
+2019-06-13  Youenn Fablet  <you...@apple.com>
+
+        Update service worker test and expectation after revision 246363
+        https://bugs.webkit.org/show_bug.cgi?id=198808
+
+        Reviewed by Geoffrey Garen.
+
+        * TestExpectations:
+        Skip timing out test in Debug
+
 2019-06-13  Miguel Gomez  <mago...@igalia.com>
 
         Unreviewed GTK+ gardening. Update expectations after r246397.

Modified: trunk/LayoutTests/TestExpectations (246402 => 246403)


--- trunk/LayoutTests/TestExpectations	2019-06-13 14:50:59 UTC (rev 246402)
+++ trunk/LayoutTests/TestExpectations	2019-06-13 15:07:18 UTC (rev 246403)
@@ -213,6 +213,7 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/update-not-allowed.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html [ Skip ]
+[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Skip ]
 
 # Newly imported service worker tests that are flaky.
 imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-to-http.https.html [ Pass Failure ]
@@ -281,7 +282,6 @@
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-order.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html [ Slow ]
-[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/multiple-update.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/activation.https.html [ Slow ]

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (246402 => 246403)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-06-13 14:50:59 UTC (rev 246402)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-06-13 15:07:18 UTC (rev 246403)
@@ -1,3 +1,14 @@
+2019-06-13  Youenn Fablet  <you...@apple.com>
+
+        Update service worker test and expectation after revision 246363
+        https://bugs.webkit.org/show_bug.cgi?id=198808
+
+        Reviewed by Geoffrey Garen.
+
+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:
+        Make sure the fetch load finishes so that removing the frame does not cancel the fetch.
+
 2019-06-12  Youenn Fablet  <you...@apple.com>
 
         Update WPT service workers test up to 0df7c68

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt (246402 => 246403)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt	2019-06-13 14:50:59 UTC (rev 246402)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt	2019-06-13 15:07:18 UTC (rev 246403)
@@ -1,7 +1,4 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: cancelled
 
-Harness Error (FAIL), message = cancelled
-
 PASS global setup 
 PASS respondWith in a task throws InvalidStateError 
 PASS respondWith in a microtask does not throw 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html (246402 => 246403)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html	2019-06-13 14:50:59 UTC (rev 246402)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html	2019-06-13 15:07:18 UTC (rev 246403)
@@ -44,10 +44,12 @@
   assert_equals(response, 'messageHandlerInitialized');
 
   // Start a fetch.
-  frame.contentWindow.fetch(url);
+  const fetchPromise = frame.contentWindow.fetch(url);
 
   // Receive the test result from the service worker.
-  return wait_for_message();
+  const result = wait_for_message();
+  await fetchPromise.then(()=> {}, () => {});
+  return result;
 };
 
 promise_test(async (t) => {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to