Log Message
Web Inspector: Dark Mode: inactive tab bar item should get darker on hover https://bugs.webkit.org/show_bug.cgi?id=199022
Reviewed by Darin Adler. * UserInterface/Views/TabBar.css: (.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover): (@media not (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon): (@media (prefers-color-scheme: dark) .tab-bar): (@media (prefers-color-scheme: dark) .tab-bar > .item): (@media (prefers-color-scheme: dark) .tab-bar > .item:not(.disabled).selected): (@media (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected):hover): (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar): (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item): (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item.selected): * UserInterface/Views/Toolbar.css: (@media (prefers-color-scheme: dark) body .toolbar):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (246665 => 246666)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-06-21 00:50:07 UTC (rev 246665)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-06-21 00:54:10 UTC (rev 246666)
@@ -1,5 +1,26 @@
2019-06-20 Devin Rousso <drou...@apple.com>
+ Web Inspector: Dark Mode: inactive tab bar item should get darker on hover
+ https://bugs.webkit.org/show_bug.cgi?id=199022
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Views/TabBar.css:
+ (.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover):
+ (@media not (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon):
+ (@media (prefers-color-scheme: dark) .tab-bar):
+ (@media (prefers-color-scheme: dark) .tab-bar > .item):
+ (@media (prefers-color-scheme: dark) .tab-bar > .item:not(.disabled).selected):
+ (@media (prefers-color-scheme: dark) .tab-bar:not(.animating) > .item:not(.selected):hover):
+ (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar):
+ (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item):
+ (@media (prefers-color-scheme: dark) body.window-inactive .tab-bar > .item.selected):
+
+ * UserInterface/Views/Toolbar.css:
+ (@media (prefers-color-scheme: dark) body .toolbar):
+
+2019-06-20 Devin Rousso <drou...@apple.com>
+
Web Inspector: Debugger: setting a breakpoint on a non-_javascript_ line should immediately show as unresolved
https://bugs.webkit.org/show_bug.cgi?id=199033
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css (246665 => 246666)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css 2019-06-21 00:50:07 UTC (rev 246665)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css 2019-06-21 00:54:10 UTC (rev 246666)
@@ -138,7 +138,7 @@
}
.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover {
- background-position: 0 100%;
+ background-image: linear-gradient(to bottom, hsl(0, 0%, 67%), hsl(0, 0%, 64%));
border-top-color: var(--tab-item-dark-border-color);
}
@@ -251,8 +251,10 @@
opacity: 0.35;
}
-.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon {
- opacity: 0.6;
+@media not (prefers-color-scheme: dark) {
+ .tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon {
+ opacity: 0.6;
+ }
}
.tab-bar > .item > .title {
@@ -360,8 +362,7 @@
@media (prefers-color-scheme: dark) {
.tab-bar {
- background-image: none;
- background-color: hsl(0, 0%, 23%);
+ background-image: linear-gradient(to bottom, hsl(0, 0%, 12%), hsl(0, 0%, 10%));
--tab-item-border-color: hsl(0, 0%, 36%);
@@ -373,8 +374,7 @@
}
.tab-bar > .item {
- background-image: none;
- background-color: hsl(0, 0%, 10%);
+ background-image: linear-gradient(to bottom, hsl(0, 0%, 12%), hsl(0, 0%, 10%));
}
.tab-bar > .item > .title {
@@ -382,13 +382,12 @@
}
.tab-bar > .item:not(.disabled).selected {
- background-image: none;
- background-color: hsl(0, 0%, 21%);
+ background-image: linear-gradient(to bottom, hsl(0, 0%, 23%), hsl(0, 0%, 21%));
border-top-color: hsl(0, 0%, 37%);
}
.tab-bar:not(.animating) > .item:not(.selected):hover {
- background-color: hsl(0, 0%, 15%);
+ background-image: linear-gradient(to bottom, hsl(0, 0%, 11%), hsl(0, 0%, 9%));
}
.tab-bar > .item > .close,
@@ -401,16 +400,16 @@
border-bottom-color: var(--tab-item-border-color);
background-image: none !important;
- background-color: hsl(0, 0%, 17%) !important;
+ background-color: hsl(0, 0%, 13%) !important;
}
body.window-inactive .tab-bar > .item {
background-image: none !important;
- background-color: hsl(0, 0%, 17%) !important;
+ background-color: hsl(0, 0%, 13%) !important;
}
body.window-inactive .tab-bar > .item.selected {
- background-color: var(--background-color) !important;
+ background-color: hsl(0, 0%, 19%) !important;
}
body.window-inactive .tab-bar > .item > .title {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (246665 => 246666)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2019-06-21 00:50:07 UTC (rev 246665)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2019-06-21 00:54:10 UTC (rev 246666)
@@ -209,7 +209,7 @@
@media (prefers-color-scheme: dark) {
body .toolbar {
- background-image: linear-gradient(to bottom, hsl(0, 0%, 25%), hsl(0, 0%, 22%));
+ background-image: linear-gradient(to bottom, hsl(0, 0%, 26%), hsl(0, 0%, 23%));
box-shadow: none;
}
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
