Title: [247227] trunk/Source/WebKit
Revision
247227
Author
timothy_hor...@apple.com
Date
2019-07-08 12:54:50 -0700 (Mon, 08 Jul 2019)

Log Message

WKWebView fails to render when another view uses CoreImage filters
https://bugs.webkit.org/show_bug.cgi?id=199488
<rdar://problem/52695825>

Reviewed by Dean Jackson.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::layerHostingModeDidChange):
Update m_layerHostingMode when it changes, even if we can't message
the Web Content process. This ensures that the next time we launch
a Web Content process, WebPageCreationParameters will have the correct
layer hosting mode, and is the usual pattern for such things.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (247226 => 247227)


--- trunk/Source/WebKit/ChangeLog	2019-07-08 19:12:00 UTC (rev 247226)
+++ trunk/Source/WebKit/ChangeLog	2019-07-08 19:54:50 UTC (rev 247227)
@@ -1,3 +1,18 @@
+2019-07-08  Tim Horton  <timothy_hor...@apple.com>
+
+        WKWebView fails to render when another view uses CoreImage filters
+        https://bugs.webkit.org/show_bug.cgi?id=199488
+        <rdar://problem/52695825>
+
+        Reviewed by Dean Jackson.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::layerHostingModeDidChange):
+        Update m_layerHostingMode when it changes, even if we can't message
+        the Web Content process. This ensures that the next time we launch
+        a Web Content process, WebPageCreationParameters will have the correct
+        layer hosting mode, and is the usual pattern for such things.
+
 2019-07-08  Wenson Hsieh  <wenson_hs...@apple.com>
 
         [iPadOS] Viewport pops while loading sohu.com, xinhuanet.com, and various other websites

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (247226 => 247227)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-07-08 19:12:00 UTC (rev 247226)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2019-07-08 19:54:50 UTC (rev 247227)
@@ -1847,15 +1847,14 @@
 
 void WebPageProxy::layerHostingModeDidChange()
 {
-    if (!hasRunningProcess())
-        return;
-
     LayerHostingMode layerHostingMode = pageClient().viewLayerHostingMode();
     if (m_layerHostingMode == layerHostingMode)
         return;
 
     m_layerHostingMode = layerHostingMode;
-    m_process->send(Messages::WebPage::SetLayerHostingMode(layerHostingMode), m_pageID);
+
+    if (hasRunningProcess())
+        m_process->send(Messages::WebPage::SetLayerHostingMode(layerHostingMode), m_pageID);
 }
 
 void WebPageProxy::waitForDidUpdateActivityState(ActivityStateChangeID activityStateChangeID)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to