Title: [247383] trunk/Source/WebCore
- Revision
- 247383
- Author
- cdu...@apple.com
- Date
- 2019-07-11 21:36:59 -0700 (Thu, 11 Jul 2019)
Log Message
Fix non-thread safe use of makeWeakPtr() under MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processInputNotify()
https://bugs.webkit.org/show_bug.cgi?id=199727
Reviewed by Eric Carlson.
Stop calling makeWeakPtr() on a main thread object from a background thread.
* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processInputNotify):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (247382 => 247383)
--- trunk/Source/WebCore/ChangeLog 2019-07-12 04:24:59 UTC (rev 247382)
+++ trunk/Source/WebCore/ChangeLog 2019-07-12 04:36:59 UTC (rev 247383)
@@ -1,3 +1,15 @@
+2019-07-11 Chris Dumez <cdu...@apple.com>
+
+ Fix non-thread safe use of makeWeakPtr() under MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processInputNotify()
+ https://bugs.webkit.org/show_bug.cgi?id=199727
+
+ Reviewed by Eric Carlson.
+
+ Stop calling makeWeakPtr() on a main thread object from a background thread.
+
+ * platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
+ (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::processInputNotify):
+
2019-07-11 Youenn Fablet <you...@apple.com>
Register a MediaStreamTrack as media producer only if it is a capture track
Modified: trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp (247382 => 247383)
--- trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp 2019-07-12 04:24:59 UTC (rev 247382)
+++ trunk/Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp 2019-07-12 04:36:59 UTC (rev 247383)
@@ -1589,7 +1589,7 @@
// Invalidate the video area
if (m_mediaPlayer) {
- callOnMainThread([weakPtr = makeWeakPtr(*m_mediaPlayer)] {
+ callOnMainThread([weakPtr = m_mediaPlayer->m_weakThis] {
if (weakPtr)
weakPtr->invalidateFrameView();
});
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
