[webkit-changes] [248146] trunk/Tools

Thu, 01 Aug 2019 20:54:07 -0700

Title: [248146] trunk/Tools
Revision
248146
Author
commit-qu...@webkit.org
Date
2019-08-01 20:50:15 -0700 (Thu, 01 Aug 2019)

Log Message

results.webkit.org: Force update cache when timeline updated
https://bugs.webkit.org/show_bug.cgi?id=200363

Patch by Zhifei Fang <zhifei_f...@apple.com> on 2019-08-01
Reviewed by Jonathan Bedard.

* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(offscreenCachedRenderFactory): Add ability to force the redraw.
(Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
(Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (248145 => 248146)


--- trunk/Tools/ChangeLog	2019-08-02 03:45:39 UTC (rev 248145)
+++ trunk/Tools/ChangeLog	2019-08-02 03:50:15 UTC (rev 248146)
@@ -1,3 +1,15 @@
+2019-08-01  Zhifei Fang  <zhifei_f...@apple.com>
+
+        results.webkit.org: Force update cache when timeline updated
+        https://bugs.webkit.org/show_bug.cgi?id=200363
+
+        Reviewed by Jonathan Bedard.
+
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+        (offscreenCachedRenderFactory): Add ability to force the redraw.
+        (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
+        (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
+
 2019-08-01  Alex Christensen  <achristen...@webkit.org>
 
         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing

Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (248145 => 248146)


--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js	2019-08-02 03:45:39 UTC (rev 248145)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js	2019-08-02 03:50:15 UTC (rev 248146)
@@ -131,7 +131,7 @@
     // This function will call redrawCache to render a offscreen cache
     // and copy the viewport area from of it
     // It will trigger redrawCache when cache don't have enough space
-    return (redrawCache, element, stateDiff, state) => {
+    return (redrawCache, element, stateDiff, state, forceRedrawCache = false) => {
         const width = typeof stateDiff.width === 'number' ? stateDiff.width : state.width;
         if (width <= 0)
             // Nothing to render
@@ -141,11 +141,19 @@
         const scrollLeft = typeof stateDiff.scrollLeft === 'number' ? stateDiff.scrollLeft : state.scrollLeft;
         const context = element.getContext('2d');
         let cachePosLeft = scrollLeft - cachedScrollLeft;
+        let needToRedrawCache = forceRedrawCache;
 
         if (element.logicWidth != width) {
             // Setup the dpr in case of blur
             setupCanvasWidthWithDpr(element, width);
+            needToRedrawCache = true;
+        } else if (cachePosLeft < 0 || cachePosLeft + width > totalWidth) {
+            if (scrollLeft < 0 )
+                return;
+            needToRedrawCache = true;
+        }
 
+        if (needToRedrawCache) {
             // We draw everything on cache
             redrawCache(offscreenCanvas, element, stateDiff, state, () => {
                 cachedScrollLeft = scrollLeft < padding ? scrollLeft : scrollLeft - padding;
@@ -155,18 +163,6 @@
                 context.clearRect(0, 0, element.width, element.height);
                 context.drawImage(offscreenCanvas, cachePosLeft * getDevicePixelRatio(), 0,    element.width, element.height, 0, 0, width * getDevicePixelRatio(), element.height);
             });
-
-        } else if (cachePosLeft < 0 || cachePosLeft + width > totalWidth) {
-            if (scrollLeft < 0 )
-                return;
-            redrawCache(offscreenCanvas, element, stateDiff, state,    () => {
-                cachedScrollLeft = scrollLeft < padding ? scrollLeft : scrollLeft - padding;
-                cachePosLeft = scrollLeft - cachedScrollLeft;
-                if (cachePosLeft < 0)
-                    cachePosLeft = 0;
-                context.clearRect(0, 0, element.width, element.height);
-                context.drawImage(offscreenCanvas, cachePosLeft * getDevicePixelRatio(), 0,    element.width, element.height, 0, 0, width * getDevicePixelRatio(), element.height);
-            });
         } else {
             if (cachePosLeft < 0)
                 cachePosLeft = 0;
@@ -367,9 +363,13 @@
         },
         onStateUpdate: (element, stateDiff, state) => {
             const context = element.getContext("2d");
+            let forceRedrawCache = false;
             if (stateDiff.scales || stateDiff.dots || typeof stateDiff.scrollLeft === 'number' || typeof stateDiff.width === 'number') {
                 console.assert(dots.length <= scales.length);
-                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state));
+                if (stateDiff.scales || stateDiff.dots) {
+                    forceRedrawCache = true;
+                }
+                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state, forceRedrawCache));
             }
         }
     });
@@ -711,10 +711,13 @@
             }
         },
         onStateUpdate: (element, stateDiff, state) => {
+            let forceRedrawCache = false;
             if (stateDiff.scales || typeof stateDiff.scrollLeft === 'number' || typeof stateDiff.width === 'number') {
-                if (stateDiff.scales)
+                if (stateDiff.scales) {
                     state.scalesMapLinkList = getScalesMapLinkList(stateDiff.scales);
-                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state));
+                    forceRedrawCache = true;
+                }
+                requestAnimationFrame(() => offscreenCachedRender(redrawCache, element, stateDiff, state, forceRedrawCache));
             }
         }
     });
@@ -722,6 +725,14 @@
     return {
         series: ListProviderReceiver((updateContainerWidth, onContainerScroll, onResize) => {
             updateContainerWidth(scales.length * scaleWidth * getDevicePixelRatio());
+            const updateData = (scales) => {
+                updateContainerWidth(scales.length * scaleWidth * getDevicePixelRatio());
+                canvasRef.setState({
+                    scales: scales
+                });
+            }
+            if (typeof option.exporter === "function")
+                option.exporter(updateData);
             onContainerScroll.action((e) => {
                 canvasRef.setState({scrollLeft: e.target.scrollLeft / getDevicePixelRatio()});
             });

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to