Title: [248673] trunk/Tools
- Revision
- 248673
- Author
- you...@apple.com
- Date
- 2019-08-14 10:10:08 -0700 (Wed, 14 Aug 2019)
Log Message
Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
https://bugs.webkit.org/show_bug.cgi?id=200706
Reviewed by Alex Christensen.
Libwebrtc is now soft-linked so we can reenable this test.
* TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (248672 => 248673)
--- trunk/Tools/ChangeLog 2019-08-14 16:39:15 UTC (rev 248672)
+++ trunk/Tools/ChangeLog 2019-08-14 17:10:08 UTC (rev 248673)
@@ -1,3 +1,15 @@
+2019-08-14 Youenn Fablet <you...@apple.com>
+
+ Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
+ https://bugs.webkit.org/show_bug.cgi?id=200706
+
+ Reviewed by Alex Christensen.
+
+ Libwebrtc is now soft-linked so we can reenable this test.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
+ (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
+
2019-08-13 Sam Weinig <wei...@apple.com>
Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm (248672 => 248673)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm 2019-08-14 16:39:15 UTC (rev 248672)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm 2019-08-14 17:10:08 UTC (rev 248673)
@@ -361,12 +361,7 @@
EXPECT_EQ(static_cast<bool>(parentalControlsShouldBeLoaded), static_cast<bool>(parentalControlsLoaded));
#endif
#if HAVE(NETWORK_EXTENSION)
- // FIXME: Libwebrtc is linking on some configurations to VideoProcessing framework which brings up NetworkExtension framework.
- // Disable this test until we find a more robust test or libwebrtc weak link VideoProcessing framework.
- // https://bugs.webkit.org/show_bug.cgi?id=180713
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300
EXPECT_EQ(static_cast<bool>(networkExtensionShouldBeLoaded), static_cast<bool>(networkExtensionLoaded));
-#endif
#endif // HAVE(NETWORK_EXTENSION)
isDone = true;
}];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
