Title: [248975] trunk/Tools
Revision
248975
Author
aakash_j...@apple.com
Date
2019-08-21 16:51:34 -0700 (Wed, 21 Aug 2019)

Log Message

[ews] Fix capitalization in Found x new Test failure message
https://bugs.webkit.org/show_bug.cgi?id=201004

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeLayoutTestsResults.report_failure):
(AnalyzeAPITestsResults.analyzeResults):
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (248974 => 248975)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-08-21 23:05:26 UTC (rev 248974)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py	2019-08-21 23:51:34 UTC (rev 248975)
@@ -1065,7 +1065,7 @@
         self.build.results = FAILURE
         pluralSuffix = 's' if len(new_failures) > 1 else ''
         new_failures_string = ', '.join([failure_name for failure_name in new_failures])
-        message = 'Found {} new Test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
+        message = 'Found {} new test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
         self.descriptionDone = message
         self.build.buildFinished([message], FAILURE)
         return defer.succeed(None)
@@ -1386,7 +1386,7 @@
             self.finished(FAILURE)
             self.build.results = FAILURE
             pluralSuffix = 's' if len(new_failures) > 1 else ''
-            message = 'Found {} new API Test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
+            message = 'Found {} new API test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
             self.descriptionDone = message
             self.build.buildFinished([message], FAILURE)
         else:

Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (248974 => 248975)


--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2019-08-21 23:05:26 UTC (rev 248974)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py	2019-08-21 23:51:34 UTC (rev 248975)
@@ -1267,7 +1267,7 @@
         self.configureStep()
         self.setProperty('first_run_failures', ["jquery/offset.html"])
         self.setProperty('second_run_failures', ["jquery/offset.html"])
-        self.expectOutcome(result=FAILURE, state_string='Found 1 new Test failure: jquery/offset.html (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Found 1 new test failure: jquery/offset.html (failure)')
         return self.runStep()
 
     def test_failure_on_clean_tree(self):
@@ -1282,7 +1282,7 @@
         self.configureStep()
         self.setProperty('first_run_failures', ['test1', 'test2'])
         self.setProperty('second_run_failures', ['test1'])
-        self.expectOutcome(result=FAILURE, state_string='Found 1 new Test failure: test1 (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Found 1 new test failure: test1 (failure)')
         return self.runStep()
 
     def test_flaky_and_inconsistent_failures_without_clean_tree_failures(self):
@@ -1350,7 +1350,7 @@
         self.setProperty('second_results_exceed_failure_limit', True)
         self.setProperty('second_run_failures', ['test{}'.format(i) for i in range(0, 30)])
         self.setProperty('clean_tree_run_failures', ['test{}'.format(i) for i in range(0, 10)])
-        self.expectOutcome(result=FAILURE, state_string='Found 30 new Test failures: test1, test0, test3, test2, test5, test4, test7, test6, test9, test8, test24, test25, test26, test27, test20, test21, test22, test23, test28, test29, test19, test18, test11, test10, test13, test12, test15, test14, test17, test16 (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Found 30 new test failures: test1, test0, test3, test2, test5, test4, test7, test6, test9, test8, test24, test25, test26, test27, test20, test21, test22, test23, test28, test29, test19, test18, test11, test10, test13, test12, test15, test14, test17, test16 (failure)')
         return self.runStep()
 
 class TestCheckOutSpecificRevision(BuildStepMixinAdditions, unittest.TestCase):

Modified: trunk/Tools/ChangeLog (248974 => 248975)


--- trunk/Tools/ChangeLog	2019-08-21 23:05:26 UTC (rev 248974)
+++ trunk/Tools/ChangeLog	2019-08-21 23:51:34 UTC (rev 248975)
@@ -1,5 +1,17 @@
 2019-08-21  Aakash Jain  <aakash_j...@apple.com>
 
+        [ews] Fix capitalization in Found x new Test failure message
+        https://bugs.webkit.org/show_bug.cgi?id=201004
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeLayoutTestsResults.report_failure):
+        (AnalyzeAPITestsResults.analyzeResults):
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
+
+2019-08-21  Aakash Jain  <aakash_j...@apple.com>
+
         Assign ews117 to EWS High-Sierra Debug queues
         https://bugs.webkit.org/show_bug.cgi?id=200993
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to