Diff
Modified: trunk/LayoutTests/ChangeLog (249173 => 249174)
--- trunk/LayoutTests/ChangeLog 2019-08-27 21:40:11 UTC (rev 249173)
+++ trunk/LayoutTests/ChangeLog 2019-08-27 21:42:32 UTC (rev 249174)
@@ -1,3 +1,15 @@
+2019-08-27 Megan Gardner <megan_gard...@apple.com>
+
+ Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed.html
+ https://bugs.webkit.org/show_bug.cgi?id=201163
+ <rdar://problem/54727027>
+
+ Reviewed by Simon Fraser.
+
+ Altering test slightly to have a reasonable test expecation on iPad.
+
+ * platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt: Added.
+
2019-08-27 Devin Rousso <drou...@apple.com>
Web Inspector: don't attach properties to `injectedScript` for the CommandLineAPI
Modified: trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt (249173 => 249174)
--- trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt 2019-08-27 21:40:11 UTC (rev 249173)
+++ trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt 2019-08-27 21:42:32 UTC (rev 249174)
@@ -1,3 +1,4 @@
-This test focuses a form, them zooms and scrolls the page. Then text is entered in the form, and we check to make sure the page has scrolled so that the input is visible again, but not more that once, as it should be visible after the first scroll.
-PASS: page has scrolled when the selection is not visible, and not scrolled when the selection is already visible.
+This test focuses a form, them zooms and scrolls the page. Then text is entered in the form, and we check to make sure the page has scrolled when needed to make the input visible again. On iPhone, the page should scroll on the first text input so that the input element in is visible again, but should not scroll more than once, as it should be visible after the first scroll. On iPad, the input should not scroll at all, as the iPad is larger and should not need to scroll for the input element to be visible. The test results should refelct these expectaitions.
+Page has scrolled on the first input
+Page has not scrolled on the second input
Modified: trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html (249173 => 249174)
--- trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html 2019-08-27 21:40:11 UTC (rev 249173)
+++ trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html 2019-08-27 21:42:32 UTC (rev 249174)
@@ -22,7 +22,7 @@
await UIHelper.activateElementAndWaitForInputSession(document.getElementById('editable'));
await UIHelper.immediateZoomToScale(3.284);
- await UIHelper.immediateScrollTo(390, 390);
+ await UIHelper.immediateScrollTo(390, 500);
await Promise.all([UIHelper.ensureVisibleContentRectUpdate(), UIHelper.ensureStablePresentationUpdate()]);
@@ -41,14 +41,16 @@
var finalXOffset = window.pageXOffset;
var finalYOffset = window.pageYOffset;
- if ((originalXOffset != secondXOffset) && (secondXOffset == finalXOffset) && (originalYOffset != secondYOffset) && (secondYOffset == finalYOffset))
- output += 'PASS: page has scrolled when the selection is not visible, and not scrolled when the selection is already visible.';
- else {
- if ((originalXOffset == secondXOffset) || (originalYOffset == secondYOffset))
- output += 'FAIL: page has failed to scrolled on the first input<br>';
- if ((secondXOffset != finalXOffset) || (secondYOffset != finalYOffset))
- output += 'FAIL: page has scrolled on the second input';
- }
+ if ((originalXOffset != secondXOffset) || (originalYOffset != secondYOffset))
+ output += 'Page has scrolled on the first input';
+ if ((originalXOffset == secondXOffset) && (originalYOffset == secondYOffset))
+ output += 'Page has not scrolled on the first input';
+ output +='<br>';
+
+ if ((secondXOffset != finalXOffset) || (secondYOffset != finalYOffset))
+ output += 'Page has scrolled on the second input.';
+ if ((secondXOffset == finalXOffset) && (secondYOffset == finalYOffset))
+ output += 'Page has not scrolled on the second input';
output += '<br>';
document.getElementById('testArea').innerHTML = output;
@@ -78,8 +80,11 @@
<body>
This test focuses a form, them zooms and scrolls the page.
Then text is entered in the form, and we check to make sure the page has scrolled
-so that the input is visible again, but not more that once, as it should be visible
-after the first scroll.
+when needed to make the input visible again. On iPhone, the page should scroll on
+the first text input so that the input element in is visible again, but should not
+scroll more than once, as it should be visible after the first scroll. On iPad, the
+input should not scroll at all, as the iPad is larger and should not need to scroll
+for the input element to be visible. The test results should refelct these expectaitions.
<div id="testArea"><input id="editable" type="text" value="Test text"></input></div>
</body>
</html>
Added: trunk/LayoutTests/platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt (0 => 249174)
--- trunk/LayoutTests/platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt 2019-08-27 21:42:32 UTC (rev 249174)
@@ -0,0 +1,4 @@
+This test focuses a form, them zooms and scrolls the page. Then text is entered in the form, and we check to make sure the page has scrolled when needed to make the input visible again. On iPhone, the page should scroll on the first text input so that the input element in is visible again, but should not scroll more than once, as it should be visible after the first scroll. On iPad, the input should not scroll at all, as the iPad is larger and should not need to scroll for the input element to be visible. The test results should refelct these expectaitions.
+Page has not scrolled on the first input
+Page has not scrolled on the second input
+
