Title: [249628] trunk/Source/WTF
- Revision
- 249628
- Author
- david_ques...@apple.com
- Date
- 2019-09-07 22:57:17 -0700 (Sat, 07 Sep 2019)
Log Message
REGRESSION(r248533): Unable to use WTF::RefCounted when building in a debug configuration against a non-debug WebKit
https://bugs.webkit.org/show_bug.cgi?id=201585
rdar://problem/55153369
Reviewed by Chris Dumez.
Export WTF::RefCountedBase::areThreadingChecksEnabledGlobally regardless of whether or not assertions
are enabled for the WTF being built. This allows WebKit-based projects to use RefCounted for their own
objects in a debug configuration without requiring a debug build of WebKit.
* wtf/RefCounted.cpp:
* wtf/RefCounted.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (249627 => 249628)
--- trunk/Source/WTF/ChangeLog 2019-09-08 05:42:51 UTC (rev 249627)
+++ trunk/Source/WTF/ChangeLog 2019-09-08 05:57:17 UTC (rev 249628)
@@ -1,3 +1,18 @@
+2019-09-07 David Quesada <david_ques...@apple.com>
+
+ REGRESSION(r248533): Unable to use WTF::RefCounted when building in a debug configuration against a non-debug WebKit
+ https://bugs.webkit.org/show_bug.cgi?id=201585
+ rdar://problem/55153369
+
+ Reviewed by Chris Dumez.
+
+ Export WTF::RefCountedBase::areThreadingChecksEnabledGlobally regardless of whether or not assertions
+ are enabled for the WTF being built. This allows WebKit-based projects to use RefCounted for their own
+ objects in a debug configuration without requiring a debug build of WebKit.
+
+ * wtf/RefCounted.cpp:
+ * wtf/RefCounted.h:
+
2019-09-07 Mark Lam <mark....@apple.com>
performJITMemcpy() source buffer should not be in the Gigacage.
Modified: trunk/Source/WTF/wtf/RefCounted.cpp (249627 => 249628)
--- trunk/Source/WTF/wtf/RefCounted.cpp 2019-09-08 05:42:51 UTC (rev 249627)
+++ trunk/Source/WTF/wtf/RefCounted.cpp 2019-09-08 05:57:17 UTC (rev 249628)
@@ -23,8 +23,6 @@
namespace WTF {
-#if !ASSERT_DISABLED
bool RefCountedBase::areThreadingChecksEnabledGlobally { false };
-#endif
}
Modified: trunk/Source/WTF/wtf/RefCounted.h (249627 => 249628)
--- trunk/Source/WTF/wtf/RefCounted.h 2019-09-08 05:42:51 UTC (rev 249627)
+++ trunk/Source/WTF/wtf/RefCounted.h 2019-09-08 05:57:17 UTC (rev 249628)
@@ -164,8 +164,8 @@
#if !ASSERT_DISABLED
mutable bool m_isOwnedByMainThread;
bool m_areThreadingChecksEnabled { true };
+#endif
WTF_EXPORT_PRIVATE static bool areThreadingChecksEnabledGlobally;
-#endif
#if CHECK_REF_COUNTED_LIFECYCLE
mutable bool m_deletionHasBegun;
mutable bool m_adoptionIsRequired;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
