Title: [249663] trunk/Tools
- Revision
- 249663
- Author
- aakash_j...@apple.com
- Date
- 2019-09-09 13:36:13 -0700 (Mon, 09 Sep 2019)
Log Message
[EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
https://bugs.webkit.org/show_bug.cgi?id=201607
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
(AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (249662 => 249663)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-09-09 20:32:59 UTC (rev 249662)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2019-09-09 20:36:13 UTC (rev 249663)
@@ -1357,12 +1357,14 @@
second_run_results = self.results.get(ReRunAPITests.name)
clean_tree_results = self.results.get(RunAPITestsWithoutPatch.name)
- if not (first_run_results and second_run_results and clean_tree_results):
+ if not (first_run_results and second_run_results):
self.finished(RETRY)
self.build.buildFinished(['Unable to parse API test results'], RETRY)
return -1
def getAPITestFailures(result):
+ if not result:
+ return set([])
# TODO: Analyze Time-out, Crash and Failure independently
return set([failure.get('name') for failure in result.get('Timedout', [])] +
[failure.get('name') for failure in result.get('Crashed', [])] +
Modified: trunk/Tools/ChangeLog (249662 => 249663)
--- trunk/Tools/ChangeLog 2019-09-09 20:32:59 UTC (rev 249662)
+++ trunk/Tools/ChangeLog 2019-09-09 20:36:13 UTC (rev 249663)
@@ -1,3 +1,14 @@
+2019-09-09 Aakash Jain <aakash_j...@apple.com>
+
+ [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
+ https://bugs.webkit.org/show_bug.cgi?id=201607
+
+ Reviewed by Jonathan Bedard.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
+ (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
+
2019-09-07 Keith Miller <keith_mil...@apple.com>
OSR entry into wasm misses some contexts
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
