Title: [249797] trunk/Source/WebInspectorUI
- Revision
- 249797
- Author
- pecor...@apple.com
- Date
- 2019-09-11 23:04:09 -0700 (Wed, 11 Sep 2019)
Log Message
Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 500ms
https://bugs.webkit.org/show_bug.cgi?id=201709
<rdar://problem/55289279>
Reviewed by Devin Rousso.
* UserInterface/Views/CPUTimelineView.js:
(WI.CPUTimelineView.prototype.layout):
Use the CPUTimelineRecord's timestamp (same as the record's endTime) as the
point when the CPU sample is taken. This aligns with the rest of the UI that
assumes that the 500ms before the sample point leads up to the sample value.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (249796 => 249797)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-09-12 05:47:26 UTC (rev 249796)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-09-12 06:04:09 UTC (rev 249797)
@@ -1,5 +1,19 @@
2019-09-11 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: REGRESSION: CPU: Overlay Markers for Thread views are off by 500ms
+ https://bugs.webkit.org/show_bug.cgi?id=201709
+ <rdar://problem/55289279>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/CPUTimelineView.js:
+ (WI.CPUTimelineView.prototype.layout):
+ Use the CPUTimelineRecord's timestamp (same as the record's endTime) as the
+ point when the CPU sample is taken. This aligns with the rest of the UI that
+ assumes that the 500ms before the sample point leads up to the sample value.
+
+2019-09-11 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Do not show override actions unless Sources tab is enabled
https://bugs.webkit.org/show_bug.cgi?id=201708
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js (249796 => 249797)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-09-12 05:47:26 UTC (rev 249796)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js 2019-09-12 06:04:09 UTC (rev 249797)
@@ -483,7 +483,7 @@
let unknownThreadAverage = 0;
for (let record of visibleRecords) {
- let time = record.startTime;
+ let time = record.timestamp;
let {usage, mainThreadUsage, workerThreadUsage, webkitThreadUsage, unknownThreadUsage} = record;
if (discontinuities.length && discontinuities[0].endTime <= time) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
