Title: [250239] trunk/Source/WebKit
- Revision
- 250239
- Author
- ddkil...@apple.com
- Date
- 2019-09-23 10:04:54 -0700 (Mon, 23 Sep 2019)
Log Message
clang-tidy: Fix unnecessary copy/ref churn of for loop variables in WebKit
<https://webkit.org/b/202096>
Reviewed by Darin Adler.
Fix unwanted copying/ref churn of loop variables by making them
const references.
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::domainsToString):
* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant presentationRectForElementUsingClosestIndicatedRect]):
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _singleTapDidReset:]):
* UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsControl textSuggestions]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (250238 => 250239)
--- trunk/Source/WebKit/ChangeLog 2019-09-23 16:48:25 UTC (rev 250238)
+++ trunk/Source/WebKit/ChangeLog 2019-09-23 17:04:54 UTC (rev 250239)
@@ -1,3 +1,22 @@
+2019-09-23 David Kilzer <ddkil...@apple.com>
+
+ clang-tidy: Fix unnecessary copy/ref churn of for loop variables in WebKit
+ <https://webkit.org/b/202096>
+
+ Reviewed by Darin Adler.
+
+ Fix unwanted copying/ref churn of loop variables by making them
+ const references.
+
+ * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+ (WebKit::domainsToString):
+ * UIProcess/ios/WKActionSheetAssistant.mm:
+ (-[WKActionSheetAssistant presentationRectForElementUsingClosestIndicatedRect]):
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _singleTapDidReset:]):
+ * UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
+ (-[WKDataListSuggestionsControl textSuggestions]):
+
2019-09-23 Chris Dumez <cdu...@apple.com>
WebPage::sessionID() does not need to get the sessionID from there WebCore Page
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (250238 => 250239)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2019-09-23 16:48:25 UTC (rev 250238)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2019-09-23 17:04:54 UTC (rev 250239)
@@ -511,7 +511,7 @@
static String domainsToString(const HashSet<RegistrableDomain>& domains)
{
StringBuilder builder;
- for (auto domainName : domains) {
+ for (const auto& domainName : domains) {
if (!builder.isEmpty())
builder.appendLiteral(", ");
builder.append('"');
Modified: trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm (250238 => 250239)
--- trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm 2019-09-23 16:48:25 UTC (rev 250238)
+++ trunk/Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm 2019-09-23 17:04:54 UTC (rev 250239)
@@ -212,7 +212,7 @@
indicatedRects.append(rect);
}
- for (auto path : WebCore::PathUtilities::pathsWithShrinkWrappedRects(indicatedRects, 0)) {
+ for (const auto& path : WebCore::PathUtilities::pathsWithShrinkWrappedRects(indicatedRects, 0)) {
auto boundingRect = path.fastBoundingRect();
if (boundingRect.contains(touchLocation))
return CGRectInset([view convertRect:(CGRect)boundingRect fromView:_view.getAutoreleased()], -presentationElementRectPadding, -presentationElementRectPadding);
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (250238 => 250239)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-09-23 16:48:25 UTC (rev 250238)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2019-09-23 17:04:54 UTC (rev 250239)
@@ -2538,7 +2538,7 @@
}
#endif
auto actionsToPerform = std::exchange(_actionsToPerformAfterResettingSingleTapGestureRecognizer, { });
- for (auto action : actionsToPerform)
+ for (const auto& action : actionsToPerform)
action();
}
Modified: trunk/Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm (250238 => 250239)
--- trunk/Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm 2019-09-23 16:48:25 UTC (rev 250238)
+++ trunk/Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm 2019-09-23 17:04:54 UTC (rev 250239)
@@ -169,7 +169,7 @@
{
NSMutableArray *suggestions = [NSMutableArray array];
- for (auto suggestion : _suggestions) {
+ for (const auto& suggestion : _suggestions) {
[suggestions addObject:[WKDataListTextSuggestion textSuggestionWithInputText:suggestion]];
if (suggestions.count == 3)
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
