Title: [251093] trunk/Source/WebCore
- Revision
- 251093
- Author
- mmaxfi...@apple.com
- Date
- 2019-10-14 14:00:32 -0700 (Mon, 14 Oct 2019)
Log Message
[Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks
https://bugs.webkit.org/show_bug.cgi?id=202778
Unreviewed.
Addressing post-review comment.
* platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::createSystemUIFont):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (251092 => 251093)
--- trunk/Source/WebCore/ChangeLog 2019-10-14 20:52:14 UTC (rev 251092)
+++ trunk/Source/WebCore/ChangeLog 2019-10-14 21:00:32 UTC (rev 251093)
@@ -1,3 +1,15 @@
+2019-10-14 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ [Cocoa] font-family:system-ui on Chinese systems don't get Chinese quote marks
+ https://bugs.webkit.org/show_bug.cgi?id=202778
+
+ Unreviewed.
+
+ Addressing post-review comment.
+
+ * platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
+ (WebCore::SystemFontDatabaseCoreText::createSystemUIFont):
+
2019-10-14 Alex Christensen <achristen...@webkit.org>
REGRESSION: [iOS 13?] TestWebKitAPI.SharedBufferTest.tryCreateArrayBufferLargeSegments is failing
Modified: trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp (251092 => 251093)
--- trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp 2019-10-14 20:52:14 UTC (rev 251092)
+++ trunk/Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp 2019-10-14 21:00:32 UTC (rev 251093)
@@ -49,6 +49,10 @@
RetainPtr<CTFontRef> SystemFontDatabaseCoreText::createSystemUIFont(const CascadeListParameters& parameters, CFStringRef locale)
{
+ // Work around a quirk of the platform API.
+ // If the passed string is empty instead of null,
+ // CoreText doesn't use the system's locale instead.
+ // We need to use the system locale in this case.
if (locale && !CFStringGetLength(locale))
locale = nullptr;
auto result = adoptCF(CTFontCreateUIFontForLanguage(kCTFontUIFontSystem, parameters.size, locale));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
