Title: [251139] trunk/Source/_javascript_Core
- Revision
- 251139
- Author
- commit-qu...@webkit.org
- Date
- 2019-10-15 09:35:05 -0700 (Tue, 15 Oct 2019)
Log Message
Interpreter: Don't assert that reference is nonnull
https://bugs.webkit.org/show_bug.cgi?id=202986
Patch by Angelos Oikonomopoulos <aoikonomopou...@igalia.com> on 2019-10-15
Reviewed by Keith Miller.
G++ 9.2 can assume that the address of a reference is nonnull and
emits multiple warnings to that effect in --debug builds.
* interpreter/FrameTracers.h:
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (251138 => 251139)
--- trunk/Source/_javascript_Core/ChangeLog 2019-10-15 16:09:55 UTC (rev 251138)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-10-15 16:35:05 UTC (rev 251139)
@@ -1,3 +1,16 @@
+2019-10-15 Angelos Oikonomopoulos <aoikonomopou...@igalia.com>
+
+ Interpreter: Don't assert that reference is nonnull
+ https://bugs.webkit.org/show_bug.cgi?id=202986
+
+ Reviewed by Keith Miller.
+
+ G++ 9.2 can assume that the address of a reference is nonnull and
+ emits multiple warnings to that effect in --debug builds.
+
+ * interpreter/FrameTracers.h:
+ (JSC::NativeCallFrameTracer::NativeCallFrameTracer):
+
2019-10-14 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r251090.
Modified: trunk/Source/_javascript_Core/interpreter/FrameTracers.h (251138 => 251139)
--- trunk/Source/_javascript_Core/interpreter/FrameTracers.h 2019-10-15 16:09:55 UTC (rev 251138)
+++ trunk/Source/_javascript_Core/interpreter/FrameTracers.h 2019-10-15 16:35:05 UTC (rev 251139)
@@ -85,7 +85,6 @@
public:
ALWAYS_INLINE NativeCallFrameTracer(VM& vm, CallFrame* callFrame)
{
- ASSERT(&vm);
ASSERT(callFrame);
ASSERT(reinterpret_cast<void*>(callFrame) < reinterpret_cast<void*>(vm.topEntryFrame));
assertStackPointerIsAligned();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
