Title: [251464] trunk/Source/WebKit
Revision
251464
Author
timothy_hor...@apple.com
Date
2019-10-22 15:59:20 -0700 (Tue, 22 Oct 2019)

Log Message

Make it possible to not include IPC Messages headers in other headers
https://bugs.webkit.org/show_bug.cgi?id=203074

* Scripts/webkit/messages_unittest.py:
(GeneratedFileContentsTest.assertHeaderEqual):
(GeneratedFileContentsTest.assertImplementationEqual):
(UnsupportedPrecompilerDirectiveTest.test_error_at_else):
(UnsupportedPrecompilerDirectiveTest.test_error_at_elif):
Fix the message generator unit tests.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (251463 => 251464)


--- trunk/Source/WebKit/ChangeLog	2019-10-22 22:46:40 UTC (rev 251463)
+++ trunk/Source/WebKit/ChangeLog	2019-10-22 22:59:20 UTC (rev 251464)
@@ -1,3 +1,15 @@
+2019-10-22  Tim Horton  <timothy_hor...@apple.com>
+
+        Make it possible to not include IPC Messages headers in other headers
+        https://bugs.webkit.org/show_bug.cgi?id=203074
+
+        * Scripts/webkit/messages_unittest.py:
+        (GeneratedFileContentsTest.assertHeaderEqual):
+        (GeneratedFileContentsTest.assertImplementationEqual):
+        (UnsupportedPrecompilerDirectiveTest.test_error_at_else):
+        (UnsupportedPrecompilerDirectiveTest.test_error_at_elif):
+        Fix the message generator unit tests.
+
 2019-10-22  Alex Christensen  <achristen...@webkit.org>
 
         Re-enable legacy TLS by default, keep runtime switch

Modified: trunk/Source/WebKit/Scripts/webkit/messages_unittest.py (251463 => 251464)


--- trunk/Source/WebKit/Scripts/webkit/messages_unittest.py	2019-10-22 22:46:40 UTC (rev 251463)
+++ trunk/Source/WebKit/Scripts/webkit/messages_unittest.py	2019-10-22 22:59:20 UTC (rev 251464)
@@ -365,11 +365,11 @@
             raise
 
     def assertHeaderEqual(self, input_messages_file_contents, expected_file_name):
-        actual_file_contents = messages.generate_messages_header(StringIO(input_messages_file_contents))
+        actual_file_contents = messages.generate_messages_header(parser.parse(StringIO(input_messages_file_contents)))
         self.assertGeneratedFileContentsEqual(actual_file_contents, expected_file_name)
 
     def assertImplementationEqual(self, input_messages_file_contents, expected_file_name):
-        actual_file_contents = messages.generate_message_handler(StringIO(input_messages_file_contents))
+        actual_file_contents = messages.generate_message_handler(parser.parse(StringIO(input_messages_file_contents)))
         self.assertGeneratedFileContentsEqual(actual_file_contents, expected_file_name)
 
 
@@ -396,11 +396,11 @@
 class UnsupportedPrecompilerDirectiveTest(unittest.TestCase):
     def test_error_at_else(self):
         with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' is not supported in the \*\.in files"):
-            messages.generate_message_handler(StringIO("asd\n#else bla\nfoo"))
+            messages.generate_message_handler(parser.parse(StringIO("asd\n#else bla\nfoo")))
 
     def test_error_at_elif(self):
         with self.assertRaisesRegexp(Exception, r"ERROR: '#elif.*' is not supported in the \*\.in files"):
-            messages.generate_message_handler(StringIO("asd\n#elif bla\nfoo"))
+            messages.generate_message_handler(parser.parse(StringIO("asd\n#elif bla\nfoo")))
 
 
 def add_reset_results_to_unittest_help():
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to